feat(zigbee): Add level step command support for ColorDimmableSwitch#12313
feat(zigbee): Add level step command support for ColorDimmableSwitch#12313P-R-O-C-H-Y wants to merge 1 commit intomasterfrom
Conversation
P-R-O-C-H-Y
added
Type: Feature request
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 90 files 90 suites 33m 33s ⏱️ Results for commit cf542bf. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
pedrominatel
left a comment
pedrominatel
left a comment
There was a problem hiding this comment.
Just one minor comment. Otherwise LGTM.
|
|
||
| **Transition time (ZCL Step command):** | ||
|
|
||
| * The transition time is the duration, in **tenths of a second**, that the device should take to perform the step. A step is a change in CurrentLevel of ``step_size`` units. |
There was a problem hiding this comment.
Maybe mentioning that each step has 100ms will make it clear.
2 participants
Description of Change
This pull request adds support for stepwise adjustment of light brightness levels to the Zigbee Color Dimmer Switch. It introduces the
setLightLevelStepcommand, allowing users to increase or decrease the brightness by a specified step size and duration, both via code and serial commands. The documentation, example usage, and keyword highlighting are updated to reflect these changes.New Level Step Functionality
setLightLevelStepmethod to theZigbeeColorDimmerSwitchclass, supporting stepwise brightness changes with various addressing modes (group, endpoint, short address, IEEE address). [1] [2]ZigbeeLevelStepDirectionenum (ZIGBEE_LEVEL_STEP_UP,ZIGBEE_LEVEL_STEP_DOWN) for specifying step direction. [1] [2]Documentation and Example Updates
ep_color_dimmer_switch.rst) to describe the newsetLightLevelStepcommand, its parameters, and usage examples.Zigbee_Color_Dimmer_Switch.ino) to handle new serial commands (stepup,stepdown,stepupfast,stepdownfast) for stepwise brightness control, and updated help text. [1] [2]Test Scenarios
Tested using 2 ESPs (C6+C5) loaded with
ColorDimmableSwitch.inoandColorDimmableLight.inoRelated links
Closes #11664