Skip to content

fix(zigbee): Set manuf_specific to 0 to use short frame header#12325

Open
P-R-O-C-H-Y wants to merge 1 commit intomasterfrom
fix/zigbee-reporting-manuf-issue
Open

fix(zigbee): Set manuf_specific to 0 to use short frame header#12325
P-R-O-C-H-Y wants to merge 1 commit intomasterfrom
fix/zigbee-reporting-manuf-issue

Conversation

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Feb 5, 2026

Description of Change

This pull request standardizes the way Zigbee attribute reporting commands are constructed across multiple sensor and endpoint classes. Specifically, it replaces the use of the manuf_code field with the manuf_specific field (set to indicate a standard profile command), and explicitly enables default responses by setting the dis_default_resp field to 0. These changes align the command structure with the Zigbee Cluster Library (ZCL) specification and improve code consistency.

This ensures, that latest HA (ZHA) version 2026.2.0 works with the Zigbee library.

Zigbee attribute reporting command updates:

Test Scenarios

Tested using ESP32C6 loaded with Temperature sensor example connected to ZHA on HA version 2026.2.0.

Related links

Issue report from homeassistant-core GH home-assistant/core#162249

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 5, 2026
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review Area: Zigbee Issues and Feature Request about Zigbee labels Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4225fe4

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP320⚠️ +120.000.00000.000.00
ESP32C3💚 -2⚠️ +40.000.00000.000.00
ESP32C5💚 -2⚠️ +40.000.00000.000.00
ESP32C6💚 -2⚠️ +40.000.00000.000.00
ESP32H2💚 -2⚠️ +40.000.00000.000.00
ESP32S20⚠️ +40.000.00000.000.00
ESP32S30⚠️ +40.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32H2ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Zigbee/examples/Zigbee_Analog_Input_Output⚠️ +120⚠️ +40⚠️ +40⚠️ +40⚠️ +40⚠️ +40⚠️ +40
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch00000000000000
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor00💚 -20💚 -20💚 -20💚 -200000
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase00💚 -20💚 -20💚 -20💚 -200000
libraries/Zigbee/examples/Zigbee_Fan_Control00000000000000
libraries/Zigbee/examples/Zigbee_Gateway000000----0000
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output⚠️ +120⚠️ +40⚠️ +40⚠️ +40⚠️ +40⚠️ +40⚠️ +40
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch00000000000000
libraries/Zigbee/examples/Zigbee_On_Off_Switch00000000000000
libraries/Zigbee/examples/Zigbee_Power_Outlet00000000000000
libraries/Zigbee/examples/Zigbee_Range_Extender00000000000000
libraries/Zigbee/examples/Zigbee_Thermostat00000000000000
libraries/Zigbee/examples/Zigbee_Binary_Input_Output----⚠️ +40⚠️ +40⚠️ +40----
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor----000000----
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light----000000----
libraries/Zigbee/examples/Zigbee_Contact_Switch----000000----
libraries/Zigbee/examples/Zigbee_Dimmable_Light----000000----
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor----💚 -20💚 -20💚 -20----
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor----000000----
libraries/Zigbee/examples/Zigbee_OTA_Client----000000----
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor----000000----
libraries/Zigbee/examples/Zigbee_On_Off_Light----000000----
libraries/Zigbee/examples/Zigbee_PM25_Sensor----000000----
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor----000000----
libraries/Zigbee/examples/Zigbee_Scan_Networks----000000----
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy----000000----
libraries/Zigbee/examples/Zigbee_Temperature_Sensor----000000----
libraries/Zigbee/examples/Zigbee_Vibration_Sensor----000000----
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor----000000----

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Test Results

 90 files   90 suites   33m 40s ⏱️
 67 tests  67 ✅ 0 💤 0 ❌
683 runs  683 ✅ 0 💤 0 ❌

Results for commit 4225fe4.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the fix/zigbee-reporting-manuf-issue branch from e9fee59 to 4225fe4 Compare February 5, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Zigbee Issues and Feature Request about Zigbee Status: Review needed Issue or PR is awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant