Skip to content

PPPClass: Add configurable boot delay after reset sequence#12344

Merged
me-no-dev merged 1 commit into
espressif:masterfrom
gonzabrusco:pppbootdelay
Feb 10, 2026
Merged

PPPClass: Add configurable boot delay after reset sequence#12344
me-no-dev merged 1 commit into
espressif:masterfrom
gonzabrusco:pppbootdelay

Conversation

@gonzabrusco
Copy link
Copy Markdown
Contributor

Description of Change

This Pull Request introduces a configurable boot delay after the modem reset sequence in PPPClass.

Previously, the code assumed that the modem would be ready to communicate approximately 100 ms after reset, which is not always true for some modules. In particular, with the SIMCom SIM7070, the modem may still be booting and not yet responsive to AT commands at that point.

To address this, a new _boot_delay parameter was added and integrated into the reset flow. This delay is applied after releasing the reset pin and before attempting to initialize the DCE or synchronize with the modem, ensuring that the modem has sufficient time to complete its boot process.

Test Scenarios

  1. Reset pin connected and controlled by PPP.setResetPin()
  2. Verified modem behavior with and without extended boot delay
  3. Confirmed that without the additional delay the modem may fail to respond to initial AT synchronization
  4. Confirmed stable and repeatable PPP startup when the boot delay is applied

Related links

#12314

These captures show the behavior with and without the boot delay commit. The time during which PWRKEY is held low for the SIM7070 to perform a reset is approximately 12.5 seconds. After the reset sequence completes, the modem requires an additional ~5 seconds to finish booting before it becomes responsive to AT commands.

Without accounting for this boot time, the PPP initialization may start too early, causing synchronization failures. The added boot delay ensures that the modem is fully operational before esp_modem_sync() and subsequent PPP initialization steps are executed.

Captures.zip

@github-actions
Copy link
Copy Markdown
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add configurable boot delay after reset sequence":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello gonzabrusco, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5967e9f

@github-actions
Copy link
Copy Markdown
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32000.000.00000.000.00
ESP32C30⚠️ +100.000.000⚠️ +160.00⚠️ +0.05
ESP32C50⚠️ +100.000.000⚠️ +160.00⚠️ +0.03
ESP32C60⚠️ +100.000.00000.000.00
ESP32H20⚠️ +100.000.000⚠️ +160.00⚠️ +0.08
ESP32P40⚠️ +100.000.000⚠️ +160.00⚠️ +0.06
ESP32S20⚠️ +40.000.00000.000.00
ESP32S30⚠️ +40.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32H2ESP32P4ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/PPP/examples/PPP_Basic00⚠️ +100⚠️ +100⚠️ +100⚠️ +10⚠️ +16⚠️ +10⚠️ +16⚠️ +40⚠️ +40
libraries/PPP/examples/PPP_WIFI_BRIDGE00⚠️ +10⚠️ +16⚠️ +10⚠️ +16⚠️ +100--⚠️ +10000⚠️ +40

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

 91 files   91 suites   31m 30s ⏱️
 67 tests  67 ✅ 0 💤 0 ❌
684 runs  684 ✅ 0 💤 0 ❌

Results for commit 5967e9f.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Feb 10, 2026
@me-no-dev me-no-dev merged commit 631ebd4 into espressif:master Feb 10, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants