Skip to content

feat(rak3112): add conditional macros for rakwireless-audio library support#12399

Merged
me-no-dev merged 2 commits into
espressif:masterfrom
Ethan-chen1234-zy:feature/rak3112-add-audio-support
Feb 25, 2026
Merged

feat(rak3112): add conditional macros for rakwireless-audio library support#12399
me-no-dev merged 2 commits into
espressif:masterfrom
Ethan-chen1234-zy:feature/rak3112-add-audio-support

Conversation

@Ethan-chen1234-zy
Copy link
Copy Markdown
Contributor

Add a variant-specific macro VARIANT_RAK3112 to pins_arduino.h to enable conditional compilation in Audio-related libraries (e.g., PDM, I2S configurations) that need to detect the RAK3112 board.

Changes
Added a header guard wrapper for RAK3112 variant at the beginning of pins_arduino.h:

#ifndef VARIANT_RAK3112
#define VARIANT_RAK3112
#endif
No other pins or definitions were modified, ensuring full backward compatibility.

Impact
This change does not affect existing functionality. It simply provides a standard way for libraries to check if the target board is RAK3112.

Testing
Compiled with Arduino IDE using board "RAK3112" and verified that the macro is correctly defined.

Tested with a custom Audio library that conditionally enables board-specific I2S pins and PDM settings; confirmed it compiles and runs without errors.

Additional Notes
This change is part of the ongoing effort to improve Audio support for RAK3112 (branch feature/rak3112-add-audio-support). The macro allows libraries to avoid hardcoding board checks based on other pins or assumptions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 24, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Ethan-chen1234-zy, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a76cd8f

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Feb 24, 2026
@me-no-dev me-no-dev merged commit fb25e62 into espressif:master Feb 25, 2026
21 checks passed
bittoby pushed a commit to bittoby/arduino-esp32 that referenced this pull request Feb 27, 2026
…upport (espressif#12399)

* feat(rak3112): add conditional macros for rakwireless-audio library support

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants