Added a define to format the spiffs in SPIFFS_Test.ino#1662
Merged
me-no-dev merged 3 commits intoespressif:masterfrom Jul 25, 2018
lbernstone:pr2
Merged
Added a define to format the spiffs in SPIFFS_Test.ino#1662me-no-dev merged 3 commits intoespressif:masterfrom lbernstone:pr2
me-no-dev merged 3 commits intoespressif:masterfrom
lbernstone:pr2
Conversation
me-no-dev
requested changes
Jul 24, 2018
Member
me-no-dev
left a comment
me-no-dev
left a comment
There was a problem hiding this comment.
Please see the comment I left :)
| // Format SPIFFS the first time you run a test | ||
| // or else use the SPIFFS plugin to create a partition | ||
| // https://github.com/me-no-dev/arduino-esp32fs-plugin | ||
| //#define FORMAT_SPIFFS true |
Member
There was a problem hiding this comment.
uncomment this define :) tests are failing. Maybe rename to FORMAT_SPIFFS_IF_FAILED to be more clear when it will be formatted.
me-no-dev
reviewed
Jul 25, 2018
| void setup(){ | ||
| Serial.begin(115200); | ||
| if(!SPIFFS.begin()){ | ||
| if(!SPIFFS.begin(FORMAT_SPIFFS)){ |
Contributor
Author
There was a problem hiding this comment.
I need AI. Mine is broken.
me-no-dev
approved these changes
Jul 25, 2018
Curclamas
pushed a commit
to Curclamas/arduino-esp32
that referenced
this pull request
Aug 21, 2018
* Added a define to format the spiffs in SPIFFS_Test.ino * Uncommented the define * Matched define names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.