added namino bianco board + other fix #8710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-R-O-C-H-Y
requested changes
Oct 5, 2023
There was a problem hiding this comment.
@a-sapuppo PTAL on my comment.
One more thing is, as you don't have an option to select more than 4MB of flash memory, I assume the board is sold with this setup. Why do you need all those partitions which may not be suitable for 4MB flash? Also PSRAM, you have there both options QSPI PSRAM and OPI PSRAM. This depends too on the chip you have on your board. If you have only one configuration of the board, one of this option will cause panic errors if selected and flashed.
Comment on lines
16
to
21
| #define NUM_DIGITAL_PINS SOC_GPIO_PIN_COUNT // GPIO 0..48 | ||
| #define NUM_ANALOG_INPUTS 20 // GPIO 1..20 | ||
| #define EXTERNAL_NUM_INTERRUPTS NUM_DIGITAL_PINS // All GPIOs | ||
| #define analogInputToDigitalPin(p) (((p)<NUM_ANALOG_INPUTS)?(analogChannelToDigitalPin(p)):-1) | ||
| #define digitalPinToInterrupt(p) (((p)<NUM_DIGITAL_PINS)?(p):NOT_AN_INTERRUPT) | ||
| #define digitalPinHasPWM(p) (p < NUM_DIGITAL_PINS) |
There was a problem hiding this comment.
Can you please remove this part? For 3.0.0 this will be automatically set in Arduino.h file for all SOCs and it's not needed to be defined there anymore.
For reference PR #8706.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this board have integrated modbus RS485, mikroe socket, qwiic i2c socket, low cost board of family