Skip to content

Conversation

@brianignacio5
Copy link
Collaborator

Description

After JTAG flash finish, close openOCD server.

Fixes #1589

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Flash (with JTag)" to flash a ESP-IDF project with jttag.
  2. Execute action. If OpenOCD is not launched a prompt will be ask to launch it.
  3. Observe results. After flash end, the openOCD server connection will end.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual steps as described above

Test Configuration:

  • ESP-IDF Version: 5.4.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@github-actions
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed OpenOCD is closed after flash is completed.
No regressions when using debug.

@brianignacio5 brianignacio5 merged commit 6481af5 into master Jul 3, 2025
6 of 7 checks passed
@brianignacio5 brianignacio5 deleted the enhance/openocd-finish-after-flash branch July 3, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When debug adapter is not running, close OpenOCD after flash. (VSC-1711)

4 participants