mise: fix vm:claude on macOS #2563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdibaiee
force-pushed
the
mahdi/mise-claude
branch
from
ffcf4af to
e4fb6ad
Compare
Member
Author
|
@jgraettinger addressed your comments and tested by re-creating a VM, works as expected. Can you also check that it works fine on yours too? |
| ssh "${HOSTNAME}" 'cat > ~/.claude/.credentials.json'; then | ||
| # Try extracting from macOS Keychain with both possible service names | ||
| if security find-generic-password -s "Claude Code-credentials" -w 2>/dev/null | \ | ||
| ssh "${HOSTNAME}" 'cat > ~/.claude/.credentials.json'; then |
Member
There was a problem hiding this comment.
compare to the diff -- this dropped logic to strip the refresh token, which shouldn't go into the VM (otherwise it breaks the host's single-use refresh token)
mdibaiee
force-pushed
the
mahdi/mise-claude
branch
from
e4fb6ad to
93df9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
~/.claude.jsonWorkflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)