DOCS: Fixing security scan issue #2576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in 'state' to help with CSRF a bit Some clean up to ensure the params are escaped
travjenkins
commented
Dec 19, 2025
Comment on lines
+13
to
+14
| const state = crypto.randomUUID() | ||
| sessionStorage.setItem(SETTINGS.storageKey, state); |
Member
Author
There was a problem hiding this comment.
This is the MAJOR update here. We need to store this off and validate it down below.
|
travjenkins
commented
Dec 19, 2025
Comment on lines
+16
to
+22
| const params = new URLSearchParams({ | ||
| client_id: SETTINGS.appId, | ||
| redirect_uri: SETTINGS.redirectUri, | ||
| resource_id: SETTINGS.resourceId, | ||
| response_type: SETTINGS.responseType, | ||
| [SETTINGS.stateKey]: state, | ||
| }); |
Member
Author
There was a problem hiding this comment.
Setting up the params in this way should handle escaping for us.
travjenkins
commented
Dec 19, 2025
Comment on lines
51
to
57
| if (authCode === "error") { | ||
| return ( | ||
| <span style={{ color: "red" }}> | ||
| We were unable to verify this worked. Please contact support. | ||
| </span> | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is where things get weird. Normally in an oAuth situation we might consume this code and do something with it. However, here we are just seeing that things are setup. So I think this is the best we could do here 🤷 .
Like if this happens either their browser messed up or possibly someone messed with their stuff and they just setup something wrong.
mdibaiee
approved these changes
Dec 21, 2025
Member
mdibaiee
left a comment
mdibaiee
left a comment
There was a problem hiding this comment.
LGTM, let me know if you need help testing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/estuary/flow/security/code-scanning/8
Description:
Escaping the
tenantnameWorkflow steps:
This will impact how Azure gets setup. This still needs tested
Documentation links affected:
Notes for reviewers:
(anything that might help someone review this PR)