Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.

Reset Context on invalid gaslimit #260

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Reset Context on invalid gaslimit #260

merged 2 commits into from
Mar 2, 2021

Conversation

ben-chain
Copy link
Collaborator

Description

This was bricking the js-vm sometimes;

Contributing Agreement

@smartcontracts
Copy link
Collaborator

Do we need reset in constructor too? Or was that only when we're using max uint256?

smartcontracts
smartcontracts previously approved these changes Mar 2, 2021
Copy link
Collaborator

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming not necessary in constructor

Copy link
Collaborator

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok LGTM

@ben-chain ben-chain merged commit 2d9e413 into master Mar 2, 2021
@ben-chain ben-chain deleted the bug/reset-context branch March 2, 2021 01:17
maurelian pushed a commit that referenced this pull request Mar 2, 2021
* add reset

* add to constructor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants