log: support context-logging #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyknox
approved these changes
May 22, 2025
Contributor
Author
|
CI is broken due to upstream EELS release issue. Fixing in #612 |
sebastianst
approved these changes
May 23, 2025
Member
sebastianst
left a comment
sebastianst
left a comment
There was a problem hiding this comment.
Would be nice to open this PR upstream! Seems like a general improvement that's compatible with the existing API.
protolambda
force-pushed
the
context-logging
branch
from
c25782e to
5950424
Compare
Signed-off-by: protolambda <[email protected]>
protolambda
force-pushed
the
context-logging
branch
from
5950424 to
b5fb988
Compare
ClaytonNorthey92
pushed a commit
to hemilabs/op-geth
that referenced
this pull request
Dec 16, 2025
* log: support context-logging * fork.yaml: document context logging extension * cmd: update logging testdata to match slog --------- Signed-off-by: protolambda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
slog.LoggerTraceContext.CritContext(crits are discouraged, and we would never want to filter from output based on context)WriteCtxto complement the existingWritemethodslog.Attrin regular log callsWriteCritmore nicelyTests
slog.Attrcan be used in regular log callsAdditional context
This helps us remove a big logging hack in our monorepo testing, so that we can do context-logging and test tracing properly.
We can also attach the devtest test-scope context to our loggers, so logs can be attributed to scopes with context.
And we can attach attributes like service-ID to package-level loggers, so we can make the log-handler easily filter down to only logs with relevant context.
Metadata