fix(op-wheel): record block base fee on its own gauge - #21127
Merged
einar-oplabs merged 1 commit intoJun 16, 2026
Conversation
Contributor
|
@claude review once |
Contributor
Author
Hey @einar-oplabs seems like the review bot didn't pick this up. |
einar-oplabs
approved these changes
Jun 15, 2026
einar-oplabs
enabled auto-merge
June 15, 2026 20:10
Contributor
|
/ci authorize 3eb72e8 |
RecordBlockStats set BlockGas twice — once with gas used and once with the base fee — which left the BlockBaseFee gauge unset and clobbered the gas gauge. Record the base fee on BlockBaseFee instead. Also fix the pre-block status log, which emitted status.Gas for the "basefee" field instead of status.BaseFee. Adds a regression test asserting gas and base fee land on their own gauges. Closes ethereum-optimism#20958
auto-merge was automatically disabled
June 16, 2026 13:33
Head branch was pushed to by a user without write access
pjdurden
force-pushed
the
fix/op-wheel-basefee-metric
branch
from
June 16, 2026 13:33
3eb72e8 to
b0f8df2
Compare
Contributor
Author
@einar-oplabs |
Contributor
einar-oplabs
enabled auto-merge
June 16, 2026 13:47
Merged
via the queue into
ethereum-optimism:develop
with commit Jun 16, 2026
bf91917
58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
op-wheel'sRecordBlockStatssetBlockGastwice — once with gas used and once with the base fee — which left theBlockBaseFeegauge unset and clobbered the gas gauge value with the base fee. This records the base fee onBlockBaseFeeinstead.The nearby pre-block status log also emitted
status.Gasfor itsbasefeefield; it now emitsstatus.BaseFee.Changes
op-wheel/engine/metrics.go—RecordBlockStatsnow setsBlockBaseFee(notBlockGas) with the base fee.op-wheel/engine/engine.go— status logbasefeefield now logsstatus.BaseFee.op-wheel/engine/metrics_test.go— addsTestRecordBlockStatsasserting gas and base fee land on their own gauges (uses distinct values so the old bug fails the test).Testing
go build ./engine/,go vet ./engine/, andgo test ./engine/all pass.go.mod/go.sumunchanged.Closes #20958