-
Notifications
You must be signed in to change notification settings - Fork 198
Rm redundant error codes #686
Copy link
Copy link
Open
Labels
A-rpcArea: RPC APIArea: RPC APIA-supervisorArea: supervisorArea: supervisorC-debtCategory: debtCategory: debtC-good-first-issueGood for newcomersGood for newcomersH-interopHardfork: change planned for Interop upgradeHardfork: change planned for Interop upgrade
Metadata
Metadata
Assignees
Labels
A-rpcArea: RPC APIArea: RPC APIA-supervisorArea: supervisorArea: supervisorC-debtCategory: debtCategory: debtC-good-first-issueGood for newcomersGood for newcomersH-interopHardfork: change planned for Interop upgradeHardfork: change planned for Interop upgrade
Remove redundant supervisor RPC error codes. Instead the error code section should mention that supervisor impls should refer to https://ethereum-json-rpc.com/errors to find a suitable catch all variant for errors which don't belong to any of the given protocol specific error codes.
https://github.com/ethereum-optimism/specs/blob/main/specs/interop/supervisor.md#protocol-specific-error-codes
Some codes seem to be only used internally by Go implementation, for example this appears to be the case for
ITER_STOPhttps://github.com/ethereum-optimism/specs/blob/main/specs/interop/supervisor.md#-321100-out_of_scope (needs investigation to confirm if this is only used internally)Others are general to any protocol and not specifically related to xmessage validation
UNINITIALIZED_CHAIN_DATABASEhttps://github.com/ethereum-optimism/specs/blob/main/specs/interop/supervisor.md#-320400-uninitialized_chain_databaseCANNOT_GET_PARENT_OF_FIRST_BLOCK_IN_DBhttps://github.com/ethereum-optimism/specs/blob/main/specs/interop/supervisor.md#-321200-cannot_get_parent_of_first_block_in_dbThe list should only contain errors specific to the interop consensus checks implemented by the supervisor.
Ref paradigmxyz/reth#15944 (comment)