chain config: move 'optimism' to 'genesis.fee_params'

[bitwiseguy]

Overview

Makes the following changes to the chain config .toml struct:

• batch_inbox_addr field moved from top level to [genesis.system_config]
• [optimism] struct renamed/moved to [genesis.fee_params]

Related Issues

Closes #969

[codecov-commenter]

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.93%. Comparing base (1139c0c) to head (c3a7112).
⚠️ Report is 143 commits behind head on main.

Files with missing lines	Patch %	Lines
ops/internal/manage/staging.go	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
+ Coverage   41.92%   41.93%   +0.01%     
==========================================
  Files          40       40              
  Lines        2674     2673       -1     
==========================================
  Hits         1121     1121              
+ Misses       1450     1449       -1     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[clabby]

This is an interesting one. The batch inbox address isn't actually in the system config that gets derived, just the contract.

The genesis system config vars, in my head, are things that can change (that the protocol supports changing in normal operation) - imo, it's fine to lift into genesis, but not genesis.system_config.

[bitwiseguy]

Ahh ok got it. Will lift it one level to genesis then. And will update the op-geth and monorepo prs accordingly

[sebastianst]

Maybe the inconsistency is that we would put this address that can be read from the system config (and that cannot be changed) into genesis.SystemConfig, but would still leave others in the addresses section. So @clabby @bitwiseguy wdyt about putting the batch inbox address into the addresses section instead?