-
Notifications
You must be signed in to change notification settings - Fork 5.1k
/enterprise url with enterprise ethereum information and resources #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…iversity of projects
…iversity of projects
Looks like a reasonable v1 to me. |
LGTM <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/enterprise/index.md
Outdated
- [Introduction to Quorum: Blockchain for the Financial Sector](https://medium.com/blockchain-at-berkeley/introduction-to-quorum-blockchain-for-the-financial-sector-58813f84e88c) | ||
|
||
|
||
## Organisations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like both "organisation" & "organization" are used on this page. @jjmstark do we have a stance on British vs. American English? I'm indifferent but it'd be nice to keep it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference either - I think the American version is more common generally, though its not my personal preference. Your call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick search through the codebase shows we already use "organization" in several places. @faraggi - please update "Organisations" to "Organizations" to keep it consistent with the other usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no problem.
I'm used to seeing both so neither shocked me, but I agree using both is like -gasp - mixing tabs and spaces!
I reached out to the EEA, and Paul DiMarzio sent the following comments:
thoughts @faraggi? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! I mentioned one small spelling update. Once that & the comments from the EEA are addressed, I feel comfortable merging this in.
docs/enterprise/index.md
Outdated
- [Introduction to Quorum: Blockchain for the Financial Sector](https://medium.com/blockchain-at-berkeley/introduction-to-quorum-blockchain-for-the-financial-sector-58813f84e88c) | ||
|
||
|
||
## Organisations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick search through the codebase shows we already use "organization" in several places. @faraggi - please update "Organisations" to "Organizations" to keep it consistent with the other usage.
Did my best to reflect that with 2 changes (intro div / why enterprise? last bullet)
My thoughts were to first list Enterprise Focused Projects that provide blockchain services.
This is directly from their docs:
I've also asked them on their chat to get a direct quote from the maintainers: https://chat.hyperledger.org/channel/sawtooth?msg=6aNDWuKhp5Ci8iQ4J [1] https://sawtooth.hyperledger.org/docs/core/releases/latest/introduction.html |
…rified "Enterprise Focused Projects" references + corrected a misdirected URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add metadata to the markdown page (sorry I didn't catch this on the first go-round!).
Added a suggestion to remove Sawtooth but I'm open to what other folks think here.
docs/enterprise/index.md
Outdated
- [Hyperledger Burrow](https://kaleido.io/) *modular blockchain client with a permissioned smart contract interpreter partially developed to the specification of the Ethereum Virtual Machine (EVM)* | ||
- [Infura](https://infura.io/) *scalable API access to the Ethereum and IPFS networks* | ||
- [Kaleido](https://kaleido.io/) *full-stack platform for building and running cross-cloud, hybrid enterprise ecosystems* | ||
- [Hyperledger Sawtooth](https://www.hyperledger.org/projects/sawtooth) *modular platform for building, deploying, and running distributed ledgers.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend removing this for now until it's clear this is an Ethereum project. We want to avoid creating confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure its an Enterprise Ethereum project, but I've gone ahead and removed the mentions for now.
…d initial description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close - looks good once the build error is addressed! See my comment.
That should've fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @jjmstark?
One last change: on the homepage, let's change the title of that section to simply say "Enterprise" instead of "Enterprise Ethereum" to make it consistent with the other subpage headers. |
…prise Signed-off-by: Felipe Faraggi <[email protected]>
@jjmstark Done. |
) * initial commit with page structure * WIP. Added most subjects and descriptions. still needs some work on diversity of projects * WIP. Added most subjects and descriptions. still needs some work on diversity of projects * fixed some minor details * internal links to /enterprise + more content + small fixes * minor fixes * review edits: edited EEA comments regarding public availability + clarified "Enterprise Focused Projects" references + corrected a misdirected URL * Added meta tags + removed sawtooth mentions (until validated) + edited initial description * minor meta tags formatting issue * homepage link to enterprise changed from enterprise ethereum to enterprise Signed-off-by: Felipe Faraggi <[email protected]>
* Add The Graph to developer tools * Add The Graph to developer tools * Change order of The Graph links * Change order of The Graph links * Quick fix, change "Besu" to "Hyperledger Besu" For technical reasons, Besu should at least contain one mention of Hyperledger Besu in it. * Add page-specific meta tags [Resolves #114] * Add issue & PR templates [Finishes #196] * /enterprise url with enterprise ethereum information and resources (#198) * initial commit with page structure * WIP. Added most subjects and descriptions. still needs some work on diversity of projects * WIP. Added most subjects and descriptions. still needs some work on diversity of projects * fixed some minor details * internal links to /enterprise + more content + small fixes * minor fixes * review edits: edited EEA comments regarding public availability + clarified "Enterprise Focused Projects" references + corrected a misdirected URL * Added meta tags + removed sawtooth mentions (until validated) + edited initial description * minor meta tags formatting issue * homepage link to enterprise changed from enterprise ethereum to enterprise Signed-off-by: Felipe Faraggi <[email protected]> * Add redirects for legacy pages [Fixes #236] (#237)
* Add The Graph to developer tools * Add The Graph to developer tools * Change order of The Graph links * Change order of The Graph links * Quick fix, change "Besu" to "Hyperledger Besu" For technical reasons, Besu should at least contain one mention of Hyperledger Besu in it. * Add page-specific meta tags [Resolves #114] * Add issue & PR templates [Finishes #196] * /enterprise url with enterprise ethereum information and resources (#198) * initial commit with page structure * WIP. Added most subjects and descriptions. still needs some work on diversity of projects * WIP. Added most subjects and descriptions. still needs some work on diversity of projects * fixed some minor details * internal links to /enterprise + more content + small fixes * minor fixes * review edits: edited EEA comments regarding public availability + clarified "Enterprise Focused Projects" references + corrected a misdirected URL * Added meta tags + removed sawtooth mentions (until validated) + edited initial description * minor meta tags formatting issue * homepage link to enterprise changed from enterprise ethereum to enterprise Signed-off-by: Felipe Faraggi <[email protected]> * Add redirects for legacy pages [Fixes #236] (#237) * Add redirects for legacy pages v2 [Fixes #236] (#240)
…n-banners Fix translation banner logic for /contributing paths
There are 3 main changes proposed in this PR:
/enterprise
page path with information on enterprise ethereum/learn
page with a link to the /enterprise pageI decided not to change the styling on the homepage intro-section (ie. to center align the block), but this could be done if needed.