Skip to content

/enterprise url with enterprise ethereum information and resources #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 17, 2019
Merged

/enterprise url with enterprise ethereum information and resources #198

merged 10 commits into from
Sep 17, 2019

Conversation

faraggi
Copy link
Contributor

@faraggi faraggi commented Sep 11, 2019

There are 3 main changes proposed in this PR:

  • added an /enterprise page path with information on enterprise ethereum
  • added a enterprise intro-block section to the homepage with links to /enterprise resources
  • added an "Enterprise Ethereum" h2+section on the /learn page with a link to the /enterprise page

I decided not to change the styling on the homepage intro-section (ie. to center align the block), but this could be done if needed.

@virgil
Copy link
Member

virgil commented Sep 11, 2019

Looks like a reasonable v1 to me.

@jdetychey
Copy link

LGTM <3

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@virgil I see you created a similar page in #189

Are you ok with me closing yours in favor of this?

- [Introduction to Quorum: Blockchain for the Financial Sector](https://medium.com/blockchain-at-berkeley/introduction-to-quorum-blockchain-for-the-financial-sector-58813f84e88c)


## Organisations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like both "organisation" & "organization" are used on this page. @jjmstark do we have a stance on British vs. American English? I'm indifferent but it'd be nice to keep it consistent.

Copy link
Contributor

@jjmstark jjmstark Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference either - I think the American version is more common generally, though its not my personal preference. Your call!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick search through the codebase shows we already use "organization" in several places. @faraggi - please update "Organisations" to "Organizations" to keep it consistent with the other usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem.
I'm used to seeing both so neither shocked me, but I agree using both is like -gasp - mixing tabs and spaces!

@jjmstark
Copy link
Contributor

jjmstark commented Sep 12, 2019

I reached out to the EEA, and Paul DiMarzio sent the following comments:

  • The language should be changed to reflect the fact that "enterprise Ethereum" doesn't mean just private networks. This is particularly relevant for the Mainnet Working Group. Instead, we should focus on Enterprise needs like privacy and permissioning.
  • A few suggested changes to the content:
    • Change "Enterprise Focused Projects" to "Enterprise Clients"
    • add Autonity under Clearmatics, and Besu under PegaSys
  • "Also curious how Sawtooth relates to Enterprise Ethereum? It’s an entire blockchain platform unto itself"

thoughts @faraggi?

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I mentioned one small spelling update. Once that & the comments from the EEA are addressed, I feel comfortable merging this in.

- [Introduction to Quorum: Blockchain for the Financial Sector](https://medium.com/blockchain-at-berkeley/introduction-to-quorum-blockchain-for-the-financial-sector-58813f84e88c)


## Organisations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick search through the codebase shows we already use "organization" in several places. @faraggi - please update "Organisations" to "Organizations" to keep it consistent with the other usage.

@faraggi
Copy link
Contributor Author

faraggi commented Sep 13, 2019

@jjmstark @samajammin

  • The language should be changed to reflect the fact that "enterprise Ethereum" doesn't mean just private networks. This is particularly relevant for the Mainnet Working Group. Instead, we should focus on Enterprise needs like privacy and permissioning.

Did my best to reflect that with 2 changes (intro div / why enterprise? last bullet)

  • Change "Enterprise Focused Projects" to "Enterprise Clients"
  • add Autonity under Clearmatics, and Besu under PegaSys

My thoughts were to first list Enterprise Focused Projects that provide blockchain services.
The next heading, Protocol and Infrastructure is about clients and protocol level tools, where Autonity is already listed.
I've changed Enterprise Focused Projects to Enterprise Focused Services in order to clarify.
Let me know if that's clear.

  • "Also curious how Sawtooth relates to Enterprise Ethereum? It’s an entire blockchain platform unto itself"

This is directly from their docs:

Hyperledger Sawtooth is an enterprise blockchain platform for building distributed ledger applications and networks. The design philosophy targets keeping ledgers distributed and making smart contracts safe, particularly for enterprise use.[1]

I've also asked them on their chat to get a direct quote from the maintainers:

https://chat.hyperledger.org/channel/sawtooth?msg=6aNDWuKhp5Ci8iQ4J
Just sent that so I'm still waiting for an answer.

[1] https://sawtooth.hyperledger.org/docs/core/releases/latest/introduction.html

…rified "Enterprise Focused Projects" references + corrected a misdirected URL
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add metadata to the markdown page (sorry I didn't catch this on the first go-round!).

Added a suggestion to remove Sawtooth but I'm open to what other folks think here.

- [Hyperledger Burrow](https://kaleido.io/) *modular blockchain client with a permissioned smart contract interpreter partially developed to the specification of the Ethereum Virtual Machine (EVM)*
- [Infura](https://infura.io/) *scalable API access to the Ethereum and IPFS networks*
- [Kaleido](https://kaleido.io/) *full-stack platform for building and running cross-cloud, hybrid enterprise ecosystems*
- [Hyperledger Sawtooth](https://www.hyperledger.org/projects/sawtooth) *modular platform for building, deploying, and running distributed ledgers.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend removing this for now until it's clear this is an Ethereum project. We want to avoid creating confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure its an Enterprise Ethereum project, but I've gone ahead and removed the mentions for now.

@faraggi faraggi requested a review from samajammin September 14, 2019 07:00
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close - looks good once the build error is addressed! See my comment.

@faraggi
Copy link
Contributor Author

faraggi commented Sep 15, 2019

That should've fixed it.
Checks are passing now, deploy successful.

@faraggi faraggi requested a review from samajammin September 15, 2019 19:58
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @jjmstark?

@jjmstark
Copy link
Contributor

One last change: on the homepage, let's change the title of that section to simply say "Enterprise" instead of "Enterprise Ethereum" to make it consistent with the other subpage headers.

@faraggi faraggi requested a review from samajammin September 17, 2019 19:31
@faraggi
Copy link
Contributor Author

faraggi commented Sep 17, 2019

@jjmstark Done.

@samajammin samajammin merged commit 8dacca4 into ethereum:dev Sep 17, 2019
samajammin pushed a commit that referenced this pull request Sep 17, 2019
)

* initial commit with page structure

* WIP. Added most subjects and descriptions. still needs some work on diversity of projects

* WIP. Added most subjects and descriptions. still needs some work on diversity of projects

* fixed some minor details

* internal links to /enterprise + more content + small fixes

* minor fixes

* review edits: edited EEA comments regarding public availability + clarified "Enterprise Focused Projects" references + corrected a misdirected URL

* Added meta tags + removed sawtooth mentions (until validated) + edited initial description

* minor meta tags formatting issue

* homepage link to enterprise changed from enterprise ethereum to enterprise

Signed-off-by: Felipe Faraggi <[email protected]>
samajammin added a commit that referenced this pull request Sep 17, 2019
* Add The Graph to developer tools

* Add The Graph to developer tools

* Change order of The Graph links

* Change order of The Graph links

* Quick fix, change "Besu" to "Hyperledger Besu"

For technical reasons, Besu should at least contain one mention of Hyperledger Besu in it.

* Add page-specific meta tags [Resolves #114]

* Add issue & PR templates [Finishes #196]

* /enterprise url with enterprise ethereum information and resources (#198)

* initial commit with page structure

* WIP. Added most subjects and descriptions. still needs some work on diversity of projects

* WIP. Added most subjects and descriptions. still needs some work on diversity of projects

* fixed some minor details

* internal links to /enterprise + more content + small fixes

* minor fixes

* review edits: edited EEA comments regarding public availability + clarified "Enterprise Focused Projects" references + corrected a misdirected URL

* Added meta tags + removed sawtooth mentions (until validated) + edited initial description

* minor meta tags formatting issue

* homepage link to enterprise changed from enterprise ethereum to enterprise

Signed-off-by: Felipe Faraggi <[email protected]>

* Add redirects for legacy pages [Fixes #236] (#237)
samajammin added a commit that referenced this pull request Sep 17, 2019
* Add The Graph to developer tools

* Add The Graph to developer tools

* Change order of The Graph links

* Change order of The Graph links

* Quick fix, change "Besu" to "Hyperledger Besu"

For technical reasons, Besu should at least contain one mention of Hyperledger Besu in it.

* Add page-specific meta tags [Resolves #114]

* Add issue & PR templates [Finishes #196]

* /enterprise url with enterprise ethereum information and resources (#198)

* initial commit with page structure

* WIP. Added most subjects and descriptions. still needs some work on diversity of projects

* WIP. Added most subjects and descriptions. still needs some work on diversity of projects

* fixed some minor details

* internal links to /enterprise + more content + small fixes

* minor fixes

* review edits: edited EEA comments regarding public availability + clarified "Enterprise Focused Projects" references + corrected a misdirected URL

* Added meta tags + removed sawtooth mentions (until validated) + edited initial description

* minor meta tags formatting issue

* homepage link to enterprise changed from enterprise ethereum to enterprise

Signed-off-by: Felipe Faraggi <[email protected]>

* Add redirects for legacy pages [Fixes #236] (#237)

* Add redirects for legacy pages v2 [Fixes #236] (#240)
TylerAPfledderer pushed a commit to TylerAPfledderer/ethereum-org-website that referenced this pull request Dec 26, 2023
…n-banners

Fix translation banner logic for /contributing paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants