This repository was archived by the owner on Dec 5, 2024. It is now read-only.
CREATE2 gas cost update #1204
Merged
CREATE2 gas cost update #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashatyrev
approved these changes
Oct 4, 2018
| DataWord size = stack.get(stack.size() - 2); | ||
| long chunkUsed = (size.longValueSafe() + 31) / 32; | ||
| long size = stack.get(stack.size() - 2).longValueSafe(); | ||
| if (size == Long.MAX_VALUE) { |
Contributor
Author
There was a problem hiding this comment.
This check is similar to check in mem gas calculation code. And looks like it's already done in a call to calcMemGas prior to this check. I'll remove it in favor of code readability.
| gasCost = gasCosts.getCREATE() + calcMemGas(gasCosts, oldMemSize, | ||
| memNeeded(stack.get(stack.size() - 2), stack.get(stack.size() - 3)), 0); | ||
| long codeSize = stack.get(stack.size() - 3).longValueSafe(); | ||
| if (codeSize == Long.MAX_VALUE) { |
zilm13
approved these changes
Oct 5, 2018
Collaborator
zilm13
left a comment
zilm13
left a comment
There was a problem hiding this comment.
I like words count instead of magic. Great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
SHA3gas cost additionReference implementation: