Add EVMC_INSUFFICIENT_BALANCE error to evmc_status_code

[yperbasis]

EVMC_BALANCE_TOO_LOW describes the situation when the caller doesn't have enough funds for value transfer. Useful on the host side for CREATE, CALL and ilk.

[chfast]

Seems fine. Do you have any particular place you will use it in?

[yperbasis]

Seems fine. Do you have any particular place you will use it in?

I'm playing with a new C++ Ethereum client, but it's just a toy at this stage.

[chfast]

Can you rebase on the master branch?

[yperbasis]

Can you rebase on the master branch?

Done.

[axic]

Could you also squash the commits? :)

[yperbasis]

Could you also squash the commits? :)

Done.

[axic]

@yperbasis could you enable maintainer edits on the fork, so that we can rebase and push to the fork to make these merges quicker?

[yperbasis]

@yperbasis could you enable maintainer edits on the fork, so that we can rebase and push to the fork to make these merges quicker?

Hmm, I don't see "Allow edits from maintainers" checkbox for some reason.

[axic]

Tried again, as last I did was a few weeks back, but it is still the case:

ERROR: Permission to torquem-ch/evmc.git denied to axic.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Maybe it is something controlled by the torquem-ch org settings?

[chfast]

GitHub orgs does not have this option. Only personal accounts.

…

On Mon, Aug 10, 2020, 19:34 Alex Beregszaszi ***@***.***> wrote: Tried again, as last I did was a few weeks back, but it is still the case: ERROR: Permission to torquem-ch/evmc.git denied to axic. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Maybe it is something controlled by the torquem-ch org settings? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#528 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEL7RH3TUUWGLYTPXRZQZ3SAAVT7ANCNFSM4OJDX36A> .

[axic]

@yperbasis sorry for letting you wait this long, it seems the gomod ci is fixed now (with #538). Could you rebase one final time and change the commit log to only contain EVMC_INSUFFICIENT_BALANCE as right now it confusingly mentions a renaming (which never took place in the final codebase) for EVMC_BALANCE_TOO_LOW.

Also for the future if you open PRs from your personal repo, we as maintainers can fix such tiny nitpicking things (including rebase) and get things merged way quicker.

[yperbasis]

@axis Done.

[axic]

Thanks!