Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

ci: Fix Gomod integration test#538

Merged
chfast merged 1 commit intomasterfrom
ci_gomod
Sep 27, 2020
Merged

ci: Fix Gomod integration test#538
chfast merged 1 commit intomasterfrom
ci_gomod

Conversation

@chfast
Copy link
Copy Markdown
Member

@chfast chfast commented Sep 27, 2020

The intention is to skip the test for external PRs as go mod does not work for fork repos. But the original script incorrectly used subshell instead of block of commands.

Proof it works now: https://app.circleci.com/pipelines/github/ethereum/evmc/1312/workflows/8dd17f41-baf4-46f8-9b4e-fe2d12e6f4b3/jobs/25360/parallel-runs/0/steps/0-104

Copy link
Copy Markdown
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chfast chfast merged commit d0987e5 into master Sep 27, 2020
@chfast chfast deleted the ci_gomod branch September 27, 2020 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants