Skip to content

The signer #16154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Apr 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
6a49fd2
signer: introduce external signer command
bas-vk Jul 12, 2017
53d6353
cmd/signer, rpc: Implement new signer. Add info about remote user to …
holiman Nov 23, 2017
fad33b1
signer: refactored request/response, made use of urfave.cli
holiman Nov 24, 2017
b8b84fe
cmd/signer: Use common flags
holiman Nov 25, 2017
08301bb
cmd/signer: methods to validate calldata against abi
holiman Nov 25, 2017
37552ec
cmd/signer: work on abi parser
holiman Nov 26, 2017
a601b38
signer: add mutex around UI
holiman Nov 27, 2017
f88559e
cmd/signer: add json 4byte directory, remove passwords from api
holiman Nov 29, 2017
39d43a7
cmd/signer: minor changes
holiman Nov 30, 2017
6f1054a
cmd/signer: Use ErrRequestDenied, enable lightkdf
holiman Dec 3, 2017
eb61c52
cmd/signer: implement tests
holiman Dec 3, 2017
d17a518
cmd/signer: made possible for UI to modify tx parameters
holiman Dec 4, 2017
d0c0b9b
cmd/signer: refactors, removed channels in ui comms, added UI-api via…
holiman Dec 6, 2017
cd84631
cmd/signer: Made lowercase json-definitions, added UI-signer test fun…
holiman Dec 6, 2017
b8c5657
cmd/signer: update documentation
holiman Dec 13, 2017
4fa2cb0
cmd/signer: fix bugs, improve abi detection, abi argument display
holiman Dec 13, 2017
92ba02a
cmd/signer: minor change in json format
holiman Dec 15, 2017
2ccae4f
cmd/signer: rework json communication
holiman Dec 16, 2017
c55fd32
cmd/signer: implement mixcase addresses in API, fix json id bug
holiman Dec 17, 2017
f743cdd
cmd/signer: rename fromaccount, update pythonpoc with new json encodi…
holiman Dec 22, 2017
ae34648
cmd/signer: make use of new abi interface
holiman Dec 28, 2017
8548d7d
signer: documentation
holiman Jan 19, 2018
c9eb319
signer/main: remove redundant option
holiman Feb 2, 2018
82dd108
signer: implement audit logging
holiman Feb 2, 2018
eb1ddba
signer: create package 'signer', minor changes
holiman Feb 5, 2018
3a9bfba
common: add 0x-prefix to mixcaseaddress in json marshalling + validation
holiman Feb 6, 2018
da312a1
signer, rules, storage: implement rules + ephemeral storage for signe…
holiman Feb 5, 2018
a8e68b9
signer: implement OnApprovedTx, change signing response (API BREAKAGE)
holiman Feb 14, 2018
99dd0a1
signer: refactoring + documentation
holiman Feb 15, 2018
3ade6cb
signer/rules: implement dispatching to next handler
holiman Feb 15, 2018
46bf5d9
signer: docs
holiman Feb 15, 2018
9458349
signer/rules: hide json-conversion from users, ensure context is cleaned
holiman Feb 15, 2018
f2538c3
signer: docs
holiman Feb 15, 2018
be24e89
signer: implement validation rules, change signature of call_info
holiman Feb 16, 2018
8bc0213
signer: fix log flaw with string pointer
holiman Feb 17, 2018
76a8c7c
signer: implement custom 4byte databsae that saves submitted signatures
holiman Feb 17, 2018
ec83d9d
signer/storage: implement aes-gcm-backed credential storage
holiman Feb 20, 2018
69a96f8
accounts: implement json unmarshalling of url
holiman Feb 22, 2018
888c11e
signer: fix listresponse, fix gas->uint64
holiman Feb 22, 2018
3096761
node: make http/ipc start methods public
holiman Mar 11, 2018
895199d
signer: add ipc capability+review concerns
holiman Mar 11, 2018
0a9df06
accounts: correct docstring
holiman Apr 11, 2018
0043e32
signer: address review concerns
holiman Apr 11, 2018
9980727
rpc: go fmt -s
holiman Apr 13, 2018
3fcee56
signer: review concerns+ baptize Clef
holiman Apr 13, 2018
8472645
signer,node: move Start-functions to separate file
holiman Apr 16, 2018
0942fcf
signer: formatting
holiman Apr 16, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions accounts/url.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,22 @@ func (u URL) MarshalJSON() ([]byte, error) {
return json.Marshal(u.String())
}

// UnmarshalJSON parses url.
func (u *URL) UnmarshalJSON(input []byte) error {
var textUrl string
err := json.Unmarshal(input, &textUrl)
if err != nil {
return err
}
url, err := parseURL(textUrl)
if err != nil {
return err
}
u.Scheme = url.Scheme
u.Path = url.Path
return nil
}

// Cmp compares x and y and returns:
//
// -1 if x < y
Expand Down
2 changes: 1 addition & 1 deletion accounts/usbwallet/hub.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (hub *Hub) refreshWallets() {
// breaking the Ledger protocol if that is waiting for user confirmation. This
// is a bug acknowledged at Ledger, but it won't be fixed on old devices so we
// need to prevent concurrent comms ourselves. The more elegant solution would
// be to ditch enumeration in favor of hutplug events, but that don't work yet
// be to ditch enumeration in favor of hotplug events, but that don't work yet
// on Windows so if we need to hack it anyway, this is more elegant for now.
hub.commsLock.Lock()
if hub.commsPend > 0 { // A confirmation is pending, don't refresh
Expand Down
2 changes: 1 addition & 1 deletion accounts/usbwallet/wallet.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ type wallet struct {
//
// As such, a hardware wallet needs two locks to function correctly. A state
// lock can be used to protect the wallet's software-side internal state, which
// must not be held exlusively during hardware communication. A communication
// must not be held exclusively during hardware communication. A communication
// lock can be used to achieve exclusive access to the device itself, this one
// however should allow "skipping" waiting for operations that might want to
// use the device, but can live without too (e.g. account self-derivation).
Expand Down
1 change: 1 addition & 0 deletions cmd/clef/4byte.json

Large diffs are not rendered by default.

Loading