build, common, contracts, log, metrics, p2p, rpc: changes necessary for swarm network rewrite merge #16886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
acud
requested review from
fjl,
gballet,
gluk256,
holiman,
karalabe and
zsfelfoldi
as code owners
acud
force-pushed
the
swarm-network-rewrite-eth-relevant-changes
branch
from
0c7f221 to
823111b
Compare
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
…y swarm-network-rewrite
Fix a spelling mistake in comment
…f bool (#16757) Fixes #16756
This commit adds many comments and removes unused code. It also removes the EmptyHash function, which had some uses but was silly.
This removes a golint warning: type name will be used as trie.TrieSync by other packages, and that stutters; consider calling this Sync. In hexToKeybytes len(hex) is even and (even+1)/2 == even/2, remove the +1.
acud
force-pushed
the
swarm-network-rewrite-eth-relevant-changes
branch
from
823111b to
a8ede7c
Compare
acud
changed the title
gballet
reviewed
Jun 4, 2018
| return sc.c.CallContext(ctx, &ignored, "shh_post", message) | ||
| func (sc *Client) Post(ctx context.Context, message whisper.NewMessage) (string, error) { | ||
| var hash string | ||
| return hash, sc.c.CallContext(ctx, &hash, "shh_post", message) |
There was a problem hiding this comment.
This has already been fixed in #16757
There was a problem hiding this comment.
probably a rebase screw-up. looked at master and it looks fine there
|
@justelad Please rebase this on master. Your PR includes a bunch of commits that were merged recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses all of the necessary changes that we've made to packages residing outside the
swarm/package.Changed packages include:
buildcommoncontractslogmetricsp2prpc- rpc/client: increased maxClientSubscriptionBuffer to 20000Discussion regarding the changes that were made as part of our merging this specific part of the code can be found here
fixes ethersphere/swarm#419