cmd/evm: change error msg output to stderr#17118
Merged
Merged
Conversation
Contributor
Author
|
@karalabe I'm sorry fixed an insignificant code, but can you take a look, please? |
fjl
requested changes
Jul 23, 2018
fjl
left a comment
Contributor
There was a problem hiding this comment.
This is a good change, but please fix the linter errors: https://travis-ci.org/ethereum/go-ethereum/jobs/399649306#L502
Contributor
Author
|
@fjl Thanks for your review, I have fixed the linter error, would you like take a look again? |
Member
|
Unfortunately this PR actually broke the |
karalabe
added a commit
that referenced
this pull request
Aug 1, 2018
Revert "cmd/evm: change error msg output to stderr (#17118)"
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
* cmd/evm: change error msg output to stderr * cmd/evm: fix some linter error
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
This reverts commit fb9f726.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the
ctx.Writerandctx.ErrWriteras output witer,before:
after: