vendor, crypto, swarm: switch over to upstream sha3 package #18390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realdave
requested review from
fjl,
holiman,
holisticode,
janos,
acud,
karalabe,
nagydani,
nolash,
nonsense,
zelig and
zsfelfoldi
as code owners
karalabe
approved these changes
Jan 4, 2019
karalabe
changed the title
dimpar
added a commit
to threshold-network/keep-core
that referenced
this pull request
Jul 4, 2019
- Import crypto/sha3 from `golang.org/x` instead of `github.com/ethereum/go-ethereum`. This change was introduced in Byzantium v1.8.21 PR: ethereum/go-ethereum#18390 For our upgrade we also need to point to golang.org/x/crypto/sha3 so the dependencies won't break.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 29, 2024
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 2, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 2, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 4, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 9, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
golang.org/x/crypto/sha3package has been updated to include bothNewLegacyKeccak256andNewLegacyKeccak512, negating the need to replicate and extend the package here.This adds the
golang.org/x/crypto/sha3dependency, removes the localcrypto/sha3package, and updates all usage accordingly.