console: handle eth.coinbase throws #19374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
console-fix-coinbase-printout
branch
from
f7e3e59 to
3baed8d
Compare
|
LGTM, Thanks! :) |
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 22, 2025
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 22, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Apr 24, 2025
* rpc: implement full bi-directional communication ethereum#18471 * console: handle eth.coinbase throws ethereum#19374 * rpc: remove extra debug log message * rpc: add go:build lines ethereum#23468
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 30, 2025
* rpc: implement full bi-directional communication ethereum#18471 * console: handle eth.coinbase throws ethereum#19374 * rpc: remove extra debug log message * rpc: add go:build lines ethereum#23468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eth.coinbaseJavaScript property can return an error (throw in JS) if there are no accounts present. This PR handles that throw in the console welcome message. The same is done foradmin.datadirif theadminnamespace is not exposed.In addition, the PR also reworks the printout so the welcome message is constructed first and only afterwards printed to avoid log messages getting intermingled with console printout.