Skip to content

console: handle eth.coinbase throws #19374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Apr 2, 2019

The eth.coinbase JavaScript property can return an error (throw in JS) if there are no accounts present. This PR handles that throw in the console welcome message. The same is done for admin.datadir if the admin namespace is not exposed.

In addition, the PR also reworks the printout so the welcome message is constructed first and only afterwards printed to avoid log messages getting intermingled with console printout.

@karalabe karalabe force-pushed the console-fix-coinbase-printout branch from f7e3e59 to 3baed8d Compare April 2, 2019 12:18
@kurkomisi
Copy link
Contributor

LGTM, Thanks! :)

@karalabe karalabe merged commit 88d7119 into ethereum:master Apr 2, 2019
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Apr 22, 2025
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Apr 22, 2025
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Apr 24, 2025
* rpc: implement full bi-directional communication ethereum#18471

* console: handle eth.coinbase throws ethereum#19374

* rpc: remove extra debug log message

* rpc: add go:build lines ethereum#23468
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Apr 30, 2025
* rpc: implement full bi-directional communication ethereum#18471

* console: handle eth.coinbase throws ethereum#19374

* rpc: remove extra debug log message

* rpc: add go:build lines ethereum#23468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants