Skip to content

graphql, node, rpc: fix typos in comments #20824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0ee8a31
errors in comments for http.go
renaynay Feb 28, 2020
b8aaf24
consistency
renaynay Feb 28, 2020
7b81c6c
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 1, 2020
8911212
correcting typos in documentation for subscription.go
renaynay Mar 1, 2020
94e2d2a
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 11, 2020
1a1aaaf
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 12, 2020
1f7c7d0
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 16, 2020
1fc5827
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 16, 2020
a01770b
node.go
renaynay Mar 23, 2020
a3204ee
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 23, 2020
c49f9b1
Merge branch 'master' into fixing-comments
renaynay Mar 23, 2020
aef6981
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 23, 2020
991237a
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 24, 2020
440ccbe
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 26, 2020
ba2c128
Merge branch 'master' of github.com:ethereum/go-ethereum
renaynay Mar 27, 2020
860d563
Merge branch 'master' into fixing-comments
renaynay Mar 27, 2020
9be013c
cleaned up comment in http.go
renaynay Feb 28, 2020
f21e840
fixed a typo in graphql service
renaynay Mar 27, 2020
74cd5de
fixed typos in my own changes
renaynay Mar 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graphql/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ type Service struct {
cors []string // Allowed CORS domains
vhosts []string // Recognised vhosts
timeouts rpc.HTTPTimeouts // Timeout settings for HTTP requests.
backend ethapi.Backend // The backend that queries will operate onn.
backend ethapi.Backend // The backend that queries will operate on.
handler http.Handler // The `http.Handler` used to answer queries.
listener net.Listener // The listening socket.
}
Expand Down
6 changes: 3 additions & 3 deletions node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (n *Node) Register(constructor ServiceConstructor) error {
return nil
}

// Start create a live P2P node and starts running it.
// Start creates a live P2P node and starts running it.
func (n *Node) Start() error {
n.lock.Lock()
defer n.lock.Unlock()
Expand Down Expand Up @@ -235,7 +235,7 @@ func (n *Node) Start() error {
// Mark the service started for potential cleanup
started = append(started, kind)
}
// Lastly start the configured RPC interfaces
// Lastly, start the configured RPC interfaces
if err := n.startRPC(services); err != nil {
for _, service := range services {
service.Stop()
Expand Down Expand Up @@ -274,7 +274,7 @@ func (n *Node) openDataDir() error {
return nil
}

// startRPC is a helper method to start all the various RPC endpoint during node
// startRPC is a helper method to start all the various RPC endpoints during node
// startup. It's not meant to be called at any time afterwards as it makes certain
// assumptions about the state of the node.
func (n *Node) startRPC(services map[reflect.Type]Service) error {
Expand Down
1 change: 0 additions & 1 deletion rpc/endpoints.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ func StartWSEndpoint(endpoint string, apis []API, modules []string, wsOrigins []
}
go NewWSServer(wsOrigins, handler).Serve(listener)
return listener, handler, err

}

// StartIPCEndpoint starts an IPC endpoint.
Expand Down
4 changes: 2 additions & 2 deletions rpc/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
http.Error(w, err.Error(), code)
return
}
// All checks passed, create a codec that reads direct from the request body
// until EOF, write the response to w, and order the server to process a
// All checks passed, create a codec that reads directly from the request body
// until EOF, writes the response to w, and orders the server to process a
// single request.
ctx := r.Context()
ctx = context.WithValue(ctx, "remote", r.RemoteAddr)
Expand Down
4 changes: 2 additions & 2 deletions rpc/subscription.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func (n *Notifier) takeSubscription() *Subscription {
return n.sub
}

// acticate is called after the subscription ID was sent to client. Notifications are
// activate is called after the subscription ID was sent to client. Notifications are
// buffered before activation. This prevents notifications being sent to the client before
// the subscription ID is sent to the client.
func (n *Notifier) activate() error {
Expand All @@ -179,7 +179,7 @@ func (n *Notifier) send(sub *Subscription, data json.RawMessage) error {
})
}

// A Subscription is created by a notifier and tight to that notifier. The client can use
// A Subscription is created by a notifier and tied to that notifier. The client can use
// this subscription to wait for an unsubscribe request for the client, see Err().
type Subscription struct {
ID ID
Expand Down