-
Notifications
You must be signed in to change notification settings - Fork 21k
trie: remove redundant returns + use stacktrie where applicable #22760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to clarify: this improvement will be noticeable mainly when we're doing snap sync, and receive a small-to-medium size storage trie. |
karalabe
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…reum#22760) * trie: add benchmark for proofless range * trie: remove unused returns + use stacktrie
9 tasks
9 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 30, 2025
…eum#22760 * trie: add benchmark for proofless range * trie: remove unused returns + use stacktrie
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 30, 2025
…eum#22760 * trie: add benchmark for proofless range * trie: remove unused returns + use stacktrie
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 3, 2025
…eum#22760 * trie: add benchmark for proofless range * trie: remove unused returns + use stacktrie
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 9, 2025
…eum#22760 * trie: add benchmark for proofless range * trie: remove unused returns + use stacktrie
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 25, 2025
…eum#22760 * trie: add benchmark for proofless range * trie: remove unused returns + use stacktrie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changed how generation works, and how the snap sync works, we stopped using some of the functionality provided by the prover.
Notably, we no longer make use of the returned
Trie
, nor theNotary
. This PR removes them as return arguments. It also makes use of theStacktrie
for the cases where we don't have any proofs, and the provided key/value pairs are expected to produce a correct state root.The first commit adds a new benchmark for this case, which exhibit quite a boost by the use of
Stacktrie
instead of the regular one: