EIP-1559 RPC changes #22834

lightclient · 2021-05-07T04:16:07Z

This branch contains EIP-1559 specific changes to the RPC, specifically:

eth_gasPrice
dynamicFeeTx can be displayed in RPC response
effectiveGasPrice is computed on-the-fly for eth_getTransaction*
add baseFee to RPC headers

A few things that haven't been addressed yet:

eth_estimateGas does not account for dynamicFeeTxs effective gas price vs. EOA balance
gas price oracle does not gracefully handle 1559 fork, it naively finds the median gas price of the previous n blocks

holiman · 2021-05-17T11:21:15Z

Trying to submit a transaction to baikal on this PR, I get

WARN [05-17|13:20:37.421] Served eth_sendTransaction               reqid=22 t=2.90379ms  err="tip higher than fee cap"

This happens when nothing is specified,

runcode = function(code){
   tx = {from: eth.accounts[0], input: code}
   eth.sendTransaction(tx)
}

holiman · 2021-05-17T11:32:54Z

Hm, also,

> runcode("0x61efef6000526010601ff3")
Error: invalid code: must not begin with 0xef
	at web3.js:6347:37(47)
	at web3.js:5081:62(37)
	at baikal.js:5:23(20)
	at <eval>:1:8(2)
>

runcode = function(code){
   tx = {from: eth.accounts[0], input: code, tip:"0x1", feeCap: "0x10"}
   eth.sendTransaction(tx)
}

It's quirky that it won't allow me to create the tx in that case

* replace GasPriceCmp and GasPriceIntCmp with FeeCapCmp, FeeCapIntCmp, TipCmp, TipIntCmp (and update all usages) * update Cost to use FeeCap instead of GasPrice

* add eip1559 status indicator * add DynamicFeeTx to transaction type check * remove underpriced transactions on minimum miner tip increases * require both a fee cap and tip bump for transaction replacement * use tip as secondary comparison criterion for priceHeap sorting

…t.Underpriced()

…transaction validation

…e post-EIP-1559 arm of pool.SetMinMinerFee()

…olRepricingKeepsLocals()

…once

…Transaction results

…acle

lightclient · 2021-05-17T14:21:52Z

It appears the issue is that because there are no txs for the gas price oracle to use to calculate a good tip, it uses the client default (1000000000) which is much higher than the recommended feeCap of 0x0a (2x the last block baseFee).

There seems like there are a couple simple ways to resolve this:

tip = min(estimatedTip, feeCap)
feeCap = max(x*parent.BaseFee(), tip)

I think setting the tip to the minimum of the either the estimatedTip or the feeCap is the weaker of the two. IIUC, the gas price oracle's goal is to return a value that will give a tx a "very high chance of being included in the following blocks". Basing the estimation around the tip makes the most sense in this case, because that is the best correlating factor for determining how quickly the tx will be included. The first solution will work in all cases except where the estimated tip greatly exceeds the feeCap. In that case, the tip will be capped by the feeCap.

The second solution will work in all cases, always returning a value to the caller that is likely to have their transaction included very soon. In the case of the Baikal, it would send a tx with a feeCap = tip = 1000000000, since that is the default minimum value configured.

lightclient · 2021-05-18T22:56:13Z

It's quirky that it won't allow me to create the tx in that case

It seems like that behaviour is consistent with other fatal vm errors. Does it make sense to make an except for this?

…ling

ryanschneider · 2021-05-24T22:12:30Z

internal/ethapi/api.go

@@ -1156,6 +1178,12 @@ func RPCMarshalHeader(head *types.Header) map[string]interface{} {
 		"transactionsRoot": head.TxHash,
 		"receiptsRoot":     head.ReceiptHash,
 	}
+
+	if head.BaseFee != nil {
+		result["baseFee"] = (*hexutil.Big)(head.BaseFee)


Suggested change

result["baseFee"] = (*hexutil.Big)(head.BaseFee)

result["baseFeePerGas"] = (*hexutil.Big)(head.BaseFee)

lightclient requested review from gballet, holiman, karalabe, MariusVanDerWijden, rjl493456442 and zsfelfoldi as code owners May 7, 2021 04:16

lightclient mentioned this pull request May 7, 2021

London hardfork tracker #22736

Closed

lightclient force-pushed the eip1559-misc branch 2 times, most recently from d4558e5 to f84e285 Compare May 10, 2021 19:31

fjl added this to the 1.10.4 milestone May 11, 2021

lightclient force-pushed the eip1559-misc branch from f84e285 to 137e14f Compare May 14, 2021 02:26

holiman mentioned this pull request May 17, 2021

all: implement eip-1559 #22837

Merged

adietrichs and others added 16 commits May 17, 2021 15:48

core/types: add 1559 compatibility to Transaction helpers

9b17b0a

* replace GasPriceCmp and GasPriceIntCmp with FeeCapCmp, FeeCapIntCmp, TipCmp, TipIntCmp (and update all usages) * update Cost to use FeeCap instead of GasPrice

core/txpool: add Tip as secondary comparison criterion on txPricedLis…

1785e33

…t.Underpriced()

core/txpool: add ErrTipAboveFeeCap error and respective check during …

ef9e28b

…transaction validation

core/txpool: refactor: create txLookup.RemotesBelowTip() to facilitat…

9209005

…e post-EIP-1559 arm of pool.SetMinMinerFee()

core/txpool: tests: add dynamicFeeTransaction() helper function

1a114fb

core/txpool: tests: create TestTransactionTypeNotSupported()

ce51585

core/txpool: tests: create TestTransactionTipAboveFeeCap()

91ea2f3

core/txpool: tests: create TestTransactionPoolRepricingDynamicFee()

ba79aa2

core/txpool: tests: add dynamic fee transactions to TestTransactionPo…

6ade382

…olRepricingKeepsLocals()

core/txpool: tests: create TestTransactionPoolUnderpricingDynamicFee()

503ad99

core/txpool: tests: create TestTransactionReplacementDynamicFee()

685ccaa

core/tx_pool_test: update signer and remove invalid type test

cff2662

core/tx_pool_test: rename dynamicFeeTransaction to dynamicFeeTx

e9de7a6

core: remove tx_list cap function

a53fac4

core/tx_pool: revert log change and simplify test

146b299

adietrichs and others added 22 commits May 17, 2021 15:49

core/types: create TxWithMinerFee wrapper

679535b

core/types, miner: add EIP-1559 support to TransactionsByMinerFeeAndN…

8c703be

…once

miner: set base fee when creating a new header

f162c37

miner: correctly handle gas limit for EIP-1559

aed8aa4

miner: correctly log block miner fees under EIP-1559

25b3556

all: rename to NewTransactionsByPriceAndNonce

034475a

core/types: rename to NewTransactionsByPriceAndNonce

26bd94c

core/types, miner: create tx.EffectiveTip(baseFee)

fb8d450

core/types: expand TestTransactionPriceNonceSort to cover 1559

55b0569

miner: activate 1559 for testGenerateBlockAndImport tests

200279f

core,miner: revert naming to TransactionsByPriceAndTime

c199228

core/types/transaction: update effective tip calculation logic

eaa7a58

miner: update aleut to london

b42d57e

core/types/transaction_test: use correct signer for 1559 txs

a8f95b8

core/types/transaction: add back sender check

8d93c95

miner/worker: calculate gas target from gas limit

a569757

miner, core: refactor CalcGasLimit

d286c19

core, miner: fix miner block limit

0930c66

core, miner: adjust block limit targetting for 1559

7a3ef74

internal/ethapi: add baseFee to RPCMarshalHeader

effc2a7

internal/ethapi: add FeeCap, Tip and correct GasPrice to EIP-1559 RPC…

a189c76

…Transaction results

core,eth,les,internal: add support for tip estimation in gas price or…

d4b5a51

…acle

lightclient force-pushed the eip1559-misc branch from 137e14f to d4b5a51 Compare May 17, 2021 14:00

internal/ethapi,eth/gasprice: don't suggest tip larger than fee cap

5d8acb2

core/types,internal: use correct eip1559 terminology for json marshal…

134a0f9

…ling

ryanschneider reviewed May 24, 2021

View reviewed changes

holiman mentioned this pull request May 28, 2021

1559 rpc #22964

Merged

lightclient closed this May 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

EIP-1559 RPC changes #22834

EIP-1559 RPC changes #22834

Uh oh!

lightclient commented May 7, 2021

Uh oh!

holiman commented May 17, 2021 •

edited

Loading

Uh oh!

holiman commented May 17, 2021

Uh oh!

lightclient commented May 17, 2021 •

edited

Loading

Uh oh!

lightclient commented May 18, 2021 •

edited

Loading

Uh oh!

ryanschneider May 24, 2021

Uh oh!

Uh oh!

	result["baseFee"] = (*hexutil.Big)(head.BaseFee)
	result["baseFeePerGas"] = (*hexutil.Big)(head.BaseFee)

EIP-1559 RPC changes #22834

EIP-1559 RPC changes #22834

Uh oh!

Conversation

lightclient commented May 7, 2021

Uh oh!

holiman commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

holiman commented May 17, 2021

Uh oh!

lightclient commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lightclient commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryanschneider May 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

holiman commented May 17, 2021 •

edited

Loading

lightclient commented May 17, 2021 •

edited

Loading

lightclient commented May 18, 2021 •

edited

Loading