revert pow removal #28749
Closed
revert pow removal #28749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and tests (ethereum#27178)" This reverts commit dde2da0.
…ereum#28340)" This reverts commit 577be37.
lgray
requested review from
s1na,
gballet,
karalabe,
holiman and
rjl493456442
as code owners
|
oops! wrong repository - my bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #28340 and updates revived tests to use various new and refactored interfaces.
A side effect to come back to, it was necessary to revert #28340 as well since the new tests weren't passing. This will need to be followed up and POS chain tests will need to be made working.
Probably a good idea is to move the current
cmd/devp2p/internal/ethtest/tocmd/devp2p/internal/ethtest_pow/bring back the newerethtestfor PoS and run both tests with corresponding chain data.