Skip to content

core/filtermaps: fixed indexer checkpoint initialization #31419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

zsfelfoldi
Copy link
Contributor

@zsfelfoldi zsfelfoldi commented Mar 18, 2025

This PR fixes a bug in the lastMapBoundaryBefore logic that resulted in incorrect checkpoint initialization (started rendering from the previous epoch boundary which caused the needTailEpoch check to fail). Apparently the bug was present before but went unnoticed because needTailEpoch behaved differently.
Fixes #31413

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just trust you that this fixes it.

@fjl fjl added this to the 1.15.6 milestone Mar 18, 2025
@fjl fjl merged commit fe640f8 into ethereum:master Mar 18, 2025
3 of 4 checks passed
sivaratrisrinivas pushed a commit to sivaratrisrinivas/go-ethereum that referenced this pull request Apr 21, 2025
)

This PR fixes a bug in the `lastMapBoundaryBefore` logic that resulted
in incorrect checkpoint initialization (started rendering from the
previous epoch boundary which caused the `needTailEpoch` check to fail).
Apparently the bug was present before but went unnoticed because
`needTailEpoch` behaved differently.
Fixes ethereum#31413
Rampex1 pushed a commit to streamingfast/go-ethereum that referenced this pull request May 15, 2025
)

This PR fixes a bug in the `lastMapBoundaryBefore` logic that resulted
in incorrect checkpoint initialization (started rendering from the
previous epoch boundary which caused the `needTailEpoch` check to fail).
Apparently the bug was present before but went unnoticed because
`needTailEpoch` behaved differently.
Fixes ethereum#31413
jakub-freebit pushed a commit to fblch/go-ethereum that referenced this pull request Jul 3, 2025
)

This PR fixes a bug in the `lastMapBoundaryBefore` logic that resulted
in incorrect checkpoint initialization (started rendering from the
previous epoch boundary which caused the `needTailEpoch` check to fail).
Apparently the bug was present before but went unnoticed because
`needTailEpoch` behaved differently.
Fixes ethereum#31413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core/filtermaps: Could not get last block of epoch
2 participants