Skip to content

AUTHORS, .mailmap: update name and email attribution #31624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

tqpcharlie
Copy link
Contributor

Hello all,
I'm no longer actively involved in blockchain development, but I figured that I should update my AUTHOR attribution, considering my name (and gender) has changed since I last contributed.
I'd be happy to verify my ownership of the old email address(es) if required.

@fjl
Copy link
Contributor

fjl commented Apr 13, 2025

It's so nice you are actually taking care of your entry there. Nobody ever does that. In order to link all your commits to your identity, we need to keep your mailmap entries from before and just need to define a new canon email for you there. The change in AUTHORS is ok.

@tqpcharlie
Copy link
Contributor Author

It's so nice you are actually taking care of your entry there. Nobody ever does that. In order to link all your commits to your identity, we need to keep your mailmap entries from before and just need to define a new canon email for you there. The change in AUTHORS is ok.

Done!

@fjl fjl added this to the 1.15.9 milestone Apr 18, 2025
@fjl
Copy link
Contributor

fjl commented Apr 20, 2025

Actually, it would be good to get a proof of the old and new email.

@fjl
Copy link
Contributor

fjl commented Apr 20, 2025

I can't see to push to the PR for some reason, but the update of .mailmap is still not done correctly. In order to associate the new name and address with the old commits, there needs to be an entry like this in .mailmap:

@fjl fjl removed this from the 1.15.9 milestone Apr 20, 2025
@tqpcharlie
Copy link
Contributor Author

Ok, updated .mailmap

@fjl
Copy link
Contributor

fjl commented Apr 29, 2025

Are you going to prove the new address though? To do this, please send an email to [email protected] from the old one, stating that you have changed to the new address.

@tqpcharlie
Copy link
Contributor Author

Are you going to prove the new address though? To do this, please send an email to [email protected] from the old one, stating that you have changed to the new address.

Done, sorry for the delay!

@fjl fjl merged commit 85b26f3 into ethereum:master May 15, 2025
2 checks passed
@fjl fjl added this to the 1.15.12 milestone May 15, 2025
@tqpcharlie tqpcharlie deleted the E_mail-update branch May 18, 2025 00:13
Dargon789 pushed a commit to Dargon789/go-ethereum that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants