Skip to content

internal/web3ext: remove the legacy backtraceAt method #31783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

JukLee0ira
Copy link
Contributor

The function BacktraceAt has been removed in #28187 . But the API end-point debug_backtraceAt is not removed from the file internal/web3ext/web3ext.go.

@JukLee0ira JukLee0ira changed the title internal: remove the legacy backtraceAt method internal/web3ex: remove the legacy backtraceAt method May 8, 2025
@JukLee0ira JukLee0ira changed the title internal/web3ex: remove the legacy backtraceAt method internal/web3ext: remove the legacy backtraceAt method May 8, 2025
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm trying to remember why exactly we removed this feature. IIRC it wasn't useful enough to port it over to our new logger, so we removed it.

@jwasinger jwasinger merged commit 07d073b into ethereum:master May 8, 2025
3 of 4 checks passed
@MariusVanDerWijden MariusVanDerWijden added this to the 1.15.12 milestone May 8, 2025
Dargon789 pushed a commit to Dargon789/go-ethereum that referenced this pull request May 27, 2025
The function `BacktraceAt` has been removed in ethereum#28187 . But the API
end-point `debug_backtraceAt` is not removed from the file
`internal/web3ext/web3ext.go`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants