cmd/geth, internal/era/eradl: add era1 downloader tool #31823
Merged
+2,642
−236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the URLs defined in checksums.txt, might as well use them.
lightclient
previously approved these changes
May 15, 2025
| } | ||
| // Shortcut if already downloaded. | ||
| if verifyHash(dstPath, hash) == nil { | ||
| fmt.Printf("%s is up-to-date\n", dstPath) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("%s is up-to-date\n", dstPath) | |
| log.Printf("%s is up-to-date\n", dstPath) |
| return nil | ||
| } | ||
|
|
||
| fmt.Printf("%s is stale\n", dstPath) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("%s is stale\n", dstPath) | |
| log.Printf("%s is stale\n", dstPath) |
| } | ||
|
|
||
| fmt.Printf("%s is stale\n", dstPath) | ||
| fmt.Printf("downloading from %s\n", url) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("downloading from %s\n", url) | |
| log.Printf("downloading from %s\n", url) |
|
I have decided to address your comments about logging the other way, by removing uses of package "log". The download output is just supposed to go straight to stdout, with package log it goes to stderr. |
fjl
changed the title
Dargon789
pushed a commit
to Dargon789/go-ethereum
that referenced
this pull request
May 27, 2025
This adds a geth subcommand for downloading era1 files and placing them into the correct location. The tool can be used even while geth is already running on the datadir. Downloads are checked against a hard-coded list of checksums for mainnet and sepolia. ``` ./geth download-era --server $SERVER --block 333333 ./geth download-era --server $SERVER --block 333333-444444 ./geth download-era --server $SERVER --epoch 0-10 ./geth download-era --server $SERVER --all ``` The implementation reuses the file downloader we already had for fetching build tools. I've done some refactoring on it to make sure it can support the new use case, and there are some changes to the build here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a subcommand for downloading era1 files and placing them into the correct location.
The tool can be used even while geth is already running on the datadir.
Downloads are checked against a hard-coded list of checksums for mainnet and sepolia.
The implementation reuses the file downloader we already had for fetching build tools. I've done some refactoring on it to make sure it can support the new use case, and there are some changes to the build here as well.