eth/catalyst: move witness methods out of api.go #31867
Merged
+295
−265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
lightclient,
fjl and
jwasinger
as code owners
|
I think we might as well remove these methods from the engine API. Peter added these as duplicates in order to make it possible to cleanly remove later. Since we have no one actively working on cross-client verification, we can just remove it now and bring this back in a good way if and when we start working on it again. |
jwasinger
approved these changes
May 21, 2025
MariusVanDerWijden
changed the title
Dargon789
pushed a commit
to Dargon789/go-ethereum
that referenced
this pull request
May 27, 2025
No functional changes, just moves the witness methods into its own file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just moves the witness methods into its own file