-
Notifications
You must be signed in to change notification settings - Fork 499
internal/libhive: client definitions, metadata file loading, client-roles #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
I think we should support multiple roles per client. |
4 tasks
This keeps old, non-updated simulations working until we update their hivesim dependency.
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [1.3.0](ethpandaops/ethereum-package@1.2.0...1.3.0) (2024-01-22) ### Features * add assertoor to additional toolings ([ethereum#419](ethpandaops/ethereum-package#419)) ([76dde3e](ethpandaops/ethereum-package@76dde3e)) * add devnets support ([ethereum#384](ethpandaops/ethereum-package#384)) ([2bae099](ethpandaops/ethereum-package@2bae099)) * add pitfalls for persistent storage as a warning ([ethereum#441](ethpandaops/ethereum-package#441)) ([69da8f0](ethpandaops/ethereum-package@69da8f0)) * add support for testnets ([ethereum#437](ethpandaops/ethereum-package#437)) ([5584cc8](ethpandaops/ethereum-package@5584cc8)) * Add Xatu Sentry ([ethereum#466](ethpandaops/ethereum-package#466)) ([b9523cb](ethpandaops/ethereum-package@b9523cb)) * enable checkpoint sync for devnets ([ethereum#448](ethpandaops/ethereum-package#448)) ([b367cfe](ethpandaops/ethereum-package@b367cfe)) * enable persistence ([ethereum#422](ethpandaops/ethereum-package#422)) ([8d40056](ethpandaops/ethereum-package@8d40056)) * enable syncing ephemery ([ethereum#459](ethpandaops/ethereum-package#459)) ([f8289cb](ethpandaops/ethereum-package@f8289cb)) * enable syncing shadowforks ([ethereum#457](ethpandaops/ethereum-package#457)) ([313a586](ethpandaops/ethereum-package@313a586)) ### Bug Fixes * add CL genesis delay to final genesis time ([ethereum#469](ethpandaops/ethereum-package#469)) ([e36027b](ethpandaops/ethereum-package@e36027b)) * add prysm-multiarch upstream image ([ethereum#451](ethpandaops/ethereum-package#451)) ([6feba23](ethpandaops/ethereum-package@6feba23)) * added supprot for boot enr file ([ethereum#456](ethpandaops/ethereum-package#456)) ([fd26e5c](ethpandaops/ethereum-package@fd26e5c)) * bump max mem limit for nimbus on holesky ([ethereum#439](ethpandaops/ethereum-package#439)) ([fb84787](ethpandaops/ethereum-package@fb84787)) * dora template fix ([ethereum#452](ethpandaops/ethereum-package#452)) ([f9243ea](ethpandaops/ethereum-package@f9243ea)) * enable ws for geth ([ethereum#446](ethpandaops/ethereum-package#446)) ([d5bf451](ethpandaops/ethereum-package@d5bf451)) * erigon chain should be set to dev ([ethereum#447](ethpandaops/ethereum-package#447)) ([1f40d84](ethpandaops/ethereum-package@1f40d84)) * erigon command arg ([ethereum#454](ethpandaops/ethereum-package#454)) ([5ae56a1](ethpandaops/ethereum-package@5ae56a1)) * fix typo ([ethereum#440](ethpandaops/ethereum-package#440)) ([933a313](ethpandaops/ethereum-package@933a313)) * guid fix for besu/teku/erigon/nimbus ([ethereum#443](ethpandaops/ethereum-package#443)) ([2283464](ethpandaops/ethereum-package@2283464)) * increase db size for geth ([ethereum#453](ethpandaops/ethereum-package#453)) ([0c67998](ethpandaops/ethereum-package@0c67998)) * logging bug ([ethereum#462](ethpandaops/ethereum-package#462)) ([f6098a1](ethpandaops/ethereum-package@f6098a1)) * parallel key generation ([ethereum#423](ethpandaops/ethereum-package#423)) ([060fd8f](ethpandaops/ethereum-package@060fd8f)) * re-add networkid ([ethereum#464](ethpandaops/ethereum-package#464)) ([4d96409](ethpandaops/ethereum-package@4d96409)) * typo ([ethereum#445](ethpandaops/ethereum-package#445)) ([e61c58a](ethpandaops/ethereum-package@e61c58a)) * Update nethermind to expose host on 0.0.0.0 ([ethereum#467](ethpandaops/ethereum-package#467)) ([0bd29dd](ethpandaops/ethereum-package@0bd29dd)) * use all enrs for nimbus via bootstrap file ([ethereum#450](ethpandaops/ethereum-package#450)) ([bb5a0c1](ethpandaops/ethereum-package@bb5a0c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Eth1 simulators should update like:
suite.Add(hivesim.ClientTestSpec{ + Role: "eth1', Run: runDiscoveryTest, Parameters: hivesim.Params{ "HIVE_LOGLEVEL": "5", }, })
To ensure the test only ever runs against the intended kind of client. If the test runner does not provide eth2 client names by accident, the old behavior still works.
Next, we can make other tests that consume "beacon", "validator", "shard-node", etc. roles.
For an Eth2 testnet, or Eth1-Eth2 merge test, multiple roles may be involved. The CLI does not change, just give it a list of involved clients. The simulator can e.g. find the first beacon node, first validator, first shard-node to run a simple testnet. Or parametrize by role, to try different combinations (e.g. for Eth2 validator <> beacon API tests, and beacon <> eth1 RPC tests).
TODO:
hive.yaml
in clients.