Sort and copyedit changelog. #8933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
May 14, 2020
Changelog.md
Outdated
| * Disallow index range accesses for arrays with dynamically encoded base types. | ||
| * Code Generator: Fixed that string literals containing backslash characters could cause incorrect code to be generated when passed directly to function calls or encoding functions when ABIEncoderV2 is active. | ||
| * Disallow index range (array slice) accesses for arrays with dynamically encoded base types. | ||
| * Fixed that string literals containing backslash characters could cause incorrect code to be generated when passed directly to function calls or encoding functions when ABIEncoderV2 is active. | ||
|
|
||
|
|
||
| Language Features: | ||
| * Implemented ``type(X).min`` and ``type(X).max`` for every integer type ``X`` that returns the smallest and largest value representable by the type. |
There was a problem hiding this comment.
Suggested change
| * Implemented ``type(X).min`` and ``type(X).max`` for every integer type ``X`` that returns the smallest and largest value representable by the type. | |
| * Implemented ``type(T).min`` and ``type(T).max`` for every integer type ``T`` that returns the smallest and largest value representable by the type. |
axic
reviewed
May 14, 2020
Changelog.md
Outdated
|
|
||
|
|
||
| Language Features: | ||
| * Implemented ``type(X).min`` and ``type(X).max`` for every integer type ``X`` that returns the smallest and largest value representable by the type. | ||
|
|
||
|
|
||
| Compiler Features: | ||
| * Commandline Interface: Don't ignore `--yul-optimizations` in assembly mode. |
There was a problem hiding this comment.
merge problem I think
ekpyron
previously approved these changes
May 14, 2020
Changelog.md
Outdated
Comment on lines
5
to
6
| * Disallow index range (array slice) accesses for arrays with dynamically encoded base types. | ||
| * Fixed that string literals containing backslash characters could cause incorrect code to be generated when passed directly to function calls or encoding functions when ABIEncoderV2 is active. |
There was a problem hiding this comment.
Suggested change
| * Disallow index range (array slice) accesses for arrays with dynamically encoded base types. | |
| * Fixed that string literals containing backslash characters could cause incorrect code to be generated when passed directly to function calls or encoding functions when ABIEncoderV2 is active. | |
| * Disallow array slices stemming from index range accesses to arrays with dynamically encoded base types. | |
| * String literals containing backslash characters can no longer cause incorrect code to be generated when passed directly to function calls or encoding functions when ABIEncoderV2 is active. |
Maybe, if we're changing them anyways :-)?
Or for the first one:
* Disallow array slices of arrays with dynamically encoded base types.
ekpyron
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.