Skip to content
This repository was archived by the owner on Jul 1, 2021. It is now read-only.

Fix missing merkle module #422

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Conversation

NIC619
Copy link
Contributor

@NIC619 NIC619 commented Mar 17, 2019

What was wrong?

ModuleNotFoundError: No module named 'eth2._utils.merkle'

How was it fixed?

  • Create eth2._utils.merkle module
  • fix mypy type checking.
    • Change helpers in common.py to @to_tuple + yield + Iterable type pattern
    • ignore type check for assigning concatenated tuples to tuple since mypy does not support it yet as suggested in this issue

Cute Animal Picture

NIC619 added 3 commits March 17, 2019 12:39
`@to_tuple`+ yield + Iterable type pattern
ignore tuple concatenation
@NIC619 NIC619 requested a review from ChihChengLiang March 17, 2019 05:30
@ChihChengLiang
Copy link
Contributor

Why isn't the ci triggered 🤔

@NIC619 NIC619 force-pushed the fix_missing_merkle_package branch from eb83c28 to 9504dd9 Compare March 17, 2019 12:38
Copy link
Contributor

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@NIC619 NIC619 merged commit 3761f68 into ethereum:master Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants