Skip to content

Bump pytest-asyncio #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2024
Merged

Bump pytest-asyncio #3368

merged 2 commits into from
Apr 29, 2024

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 29, 2024 •
edited
Loading

What was wrong?

pytest/pytest-asyncio had a bug: pytest-dev/pytest#12269.

How was it fixed?

pytest-asyncio has the fix released in 0.21.2.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review April 29, 2024 16:56
@kclowes kclowes requested review from reedsa, fselmo and pacrob April 29, 2024 16:57
pacrob
pacrob approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

fselmo
fselmo approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just looking at this too. LGTM. Any idea if we can / should update to latest pytest-asyncio or do we still need to keep that below 0.23 for now?

@kclowes
Copy link
Collaborator Author

kclowes commented Apr 29, 2024

There is still an issue with pytest-asyncio v0.23: https://app.circleci.com/pipelines/github/ethereum/web3.py/6364/workflows/39dd2cdd-16d7-49e5-b39e-28e468c7239c/jobs/453459. I think it's a bug on their end that they're working on.

@fselmo
Copy link
Collaborator

fselmo commented Apr 29, 2024

There is still an issue with pytest-asyncio v0.23: https://app.circleci.com/pipelines/github/ethereum/web3.py/6364/workflows/39dd2cdd-16d7-49e5-b39e-28e468c7239c/jobs/453459. I think it's a bug on their end that they're working on.

Good to know! Thanks for checking. lgtm

@kclowes kclowes merged commit 51ba379 into ethereum:v6 Apr 29, 2024
99 checks passed
@kclowes kclowes deleted the fix-ci branch April 29, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob pacrob approved these changes

@reedsa reedsa Awaiting requested review from reedsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kclowes @fselmo @pacrob