fix: Base cumulative functions return all NA after the first NA#326
Merged
etiennebacher merged 2 commits intoetiennebacher:mainfrom Feb 16, 2026
Merged
Conversation
Owner
|
Thanks, can you update NEWS? |
Contributor
Author
|
Oh, I forgot to update the NEWS.md. I'm enjoying the Chinese New Year today 🎇. Can you please update it? Thank you and wish you Happy Lunar New Year ❤️! |
Owner
|
Sure, done! Enjoy the celebrations :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325
I modified the
pl_cum_*()functions, which use a boolean mask to make Polars and baseR behave consistently:This does not significantly increase computational complexity, nor does it break the LazyFrame. All tests passed.
Additionally, I added a test for the mathematical functions with NA in
tests/testthat/test-funs_math.R.