Replace parseurl with WHATWG URL API #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More information here: e18e/ecosystem-issues#160
Saturate
changed the title
|
Stale pull request message |
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the use of the deprecated parseurl package with the WHATWG URL API to obtain the pathname from the request object.
- Removed dependency on parseurl
- Updated logic for retrieving the request pathname using the WHATWG URL API
Files not reviewed (1)
- package.json: Language not supported
| @@ -119,7 +118,7 @@ defineGetter(req, 'subdomains', function subdomains() { | |||
| }); | |||
|
|
|||
| defineGetter(req, 'path', function path() { | |||
| return parse(this).pathname; | |||
| return new URL(this).pathname; | |||
There was a problem hiding this comment.
Using 'new URL(this)' may throw an error if 'this' does not contain an absolute URL. Consider providing a valid absolute URL string or a base URL as the second parameter to ensure proper parsing.
Suggested change
| return new URL(this).pathname; | |
| const baseUrl = `${this.protocol || 'http'}://${this.host || 'localhost'}`; | |
| return new URL(this.url, baseUrl).pathname; |
Copilot uses AI. Check for mistakes.
|
Stale pull request message |
Hmm, ok? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information here:
e18e/ecosystem-issues#160