Add additional argument for generating msgstr in order to create *.po files

[pospi]

No description provided.

[pospi]

See also formatjs/babel-plugin-react-intl#31 (comment)

[evenchange4]

Would you mind providing more details about your translation workflow?
To be honest I could not figure out why skipping the 'pot' step. 🤔

[pospi]

Well, I'm sure you know a *.pot file is just a *.po file with translations missing- they're the same format, one is just a template. I'm not advocating only doing the *.po step, but I would like to generate both a *.pot template and a ready-to-go translation file for the default language the app is built in, using the defaultMessage feature of react-intl. Mainly because I can then pipe that into other tools to generate merged translation files for the default language that aren't spread out through defaultMessage attributes in your app. Maybe it's a rare case but that's why I avoided disturbing the default behaviour. Others could concievably have different app source directories with different languages built into them as the default language which this would assist with too.

[evenchange4]

Just a reminder that there is already a built in algorithm working internally of react-intl. It will automatically fallback to defaultMessage if the message id is not matched in your translation files. (Maybe not the only solution.)

Anyway, thanks for sharing the process of your project, and it's ok for me to merge this PR if it is ready. :)

[pospi]

Yeah, so many options aren't there! Ready to merge if you're happy to have these features in the core project (:

[pospi]

Yeah, so many options aren't there! Well I'm ready if you are and you're
happy for this feature to be part of the core (:

On Mon, Oct 24, 2016 at 8:41 PM Michael Hsu [email protected]
wrote:

Just a reminder that there is already a built in algorithm
https://github.com/yahoo/react-intl/wiki/API#message-formatting-fallbacks
working internally of react-intl. It will automatically fallback to
defaultMessage if the message id is not matched in your translation
files. (Maybe not the only solution.)

Anyway, thanks for sharing the process of your project, and I am okay to
merge this PR if it is ready. :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#45 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAatJHRech5KhDm4ne6oVHBVjARNFpQ4ks5q3ItOgaJpZM4Kdzab
.

[evenchange4]

Add another test case for custom messageValue will be great. :)

[evenchange4]

There is an eslint error here, please fix it or alternatively just adding one line eslint-disable for pretty display. :)

ps: Rebase onto master branch which now using node v6 and npm v3 and just run npm run lint locally.