Added conventional resolution of the connector using connection string #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
dumbo_db_resolution
branch
from
6e61480 to
3e9b2eb
Compare
oskardudycz
force-pushed
the
dumbo_db_resolution
branch
3 times, most recently
from
fb083a0 to
d321253
Compare
oskardudycz
force-pushed
the
dumbo_db_resolution
branch
6 times, most recently
from
178d277 to
df65e01
Compare
oskardudycz
force-pushed
the
dumbo_db_resolution
branch
from
df65e01 to
7abb90b
Compare
davecosec
reviewed
Jun 10, 2025
| @@ -3,11 +3,16 @@ import 'dotenv/config'; | |||
| import Benchmark from 'benchmark'; | |||
| import pg from 'pg'; | |||
| import { rawSql, single } from '..'; | |||
| import { defaultPostgreSQLConenctionString, dumbo } from '../pg'; | |||
| import { | |||
| defaultPostgreSQLConenctionString, | |||
There was a problem hiding this comment.
Nice catch, fixed 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to that, it'll be possible to use Dumbo with the default access by passing connection string, then on the first execution the connection pool will be evaluated and resolved based on parsing connection string.
This will make database switching easier and more manageable. Promise resolution is cached, so only a slight performance hit will be added (it should not be noticeable for most cases).
Pongo is still just using PostgreSQL; generic database resolution for it will need to come as a follow-up.
More testing for SQLite will need to come, but I don't want to keep this PR hanging for too long. It was already open for 3 months.