fix: stabilize page curl backside transitions#555
Merged
Conversation
Introduce shared page curl planning and safe controller assignment for DIVINA and EPUB readers. Use a dedicated backside view controller style so curl backside rendering follows reader background instead of the system default bright backside. Route all page curl setViewControllers calls through a helper that normalizes controller counts to match runtime spine requirements, and keep initial programmatic jumps non-animated to avoid startup transition glitches. Also keep control chip horizontal padding consistent with default spacing in divina and pdf overlays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageCurlBacksideViewControllerto render a custom backside color (with configurable fill/dim opacity) for page-curl transitionsPageCurlControllerPlannerto centralize page-curl runtime setup, controller-count planning, and safesetViewControllersnormalizationTesting
make formatmake build