Swift3 #1
Open
Swift3 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd wherever possible let the migrator do its job and left that source changed intact. When the swift code continued to fail compilation, fixed in place. Ported the test cases to Swift 3. In some cases needed to customize code fixes where Swift 3 is broke, or Xcode 8 is broke. Utilized Xcode 8.1 beta 3 version to get the most up to date compiler changes. For external pods: GRMustache.swift -> using the Swift3 branch (as its not completed and merged to master yet), Fuzi (latest master is Swift 3, but including all commits after latest release build), Try (unchanged)
…l pod references.
…y updated to Swift 3! Updated CDAKit.podspec and Podfile
…d a forked repo that is. Attempting to use that instead.
…the three source files (WBTry.m, WBTry.h, trap.swift) internally, and modified trap.swift to make it Swift 3, and fixed up the CDAKit.h / umbrella framework / bridging header to use this.
… successfully at this moment: cleaned up some warnings, fixed up one test (EntryTest, test_from_event_hash, needing to change the hash["code"]! to have two exclamation points for double optional reduction like the rest of the XCTAssertEqual tests)
…ord.swift into 4 pieces. It may not need to actually be in 4 pieces, as I believe the val dictionary was the culprit (its a Swift compiler bug in 8.1) but now it cleanly compiles and all tests succeed in Xcode 8.1 GM
…Now everything should be back to where it originally was after the main port to Swift 3.
…bug failure with record.swift is resolved.
…ft 3 (Version 2.0.0). So restoring that back in, removing local copies. Now all three pods: GRMustache.swift, Fuzi, and Try have release updates supporting Xcode 8 and Swift 3.
…) and remove the local inclusion of Try
|
I wish they had accepted your pull request... you did great work. Have you forked this project somehow for using newer Swift versions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eric: Great work!! CDAKit ported to Swift is an awesome find and will be a great asset to developers like myself who want to work with CDA using Swift on iOS. But as it is currently it will not work in the released builds of XCode or newer Swift, or natively in iOS 10. So I ported this to Swift 3 and XCode 8. I also did some more cleanup work so it also builds and runs in XCode 8.1 for iOS 10.1. Pods GRMustache.swift, Fuzi, and Try have also (just now) been ported to Swift 3 also. So now CDAKit takes advantage of this in this Swift3 branch I did. I also ported the test code to Swift 3 and using the pod ports so now you can build all this in XCode 8 or XCode 8.1. All tests will build and run successfully. I did attempt some massaging of the release doc for a new release but you will probably need to clean that up more.