-
Notifications
You must be signed in to change notification settings - Fork 15
Support adding default tags as discrete values in LoggerConfiguration… #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
niemyjski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks good, we can simplify the add tags check and remove linq :).
src/Serilog.Sinks.Exceptionless/Sinks/Exceptionless/ExceptionlessSink.cs
Outdated
Show resolved
Hide resolved
|
If the PR will be accepted and merged, could be new version of the nuget package released, please? |
|
Thanks for the pr |
|
I was looking at this and thinking it would be good to all DefaultData to be added to as well, but then I thought... this logging sink has to be using an ExceptionlessClient instance under the hood... why don't we just configure these things on the client? I guess it doesn't hurt anything and make it more discoverable to have them here as well. |
|
Thank you for merging. I can see there is new version v89 released, but the nupkg asset has still old version (3.1.3). Could the new version (3.1.4) be released also to NuGet public gallery, please? |
|
@ejsmith I can see the sink creates new instance of the BTW I cannot see the issue tracker in this project, but maybe it would be nice having it for similar discussions. |
|
I just pushed a new version. |
… extension
Motivation
When Exceptionles sink is used together with serilog-settings-configuration package then it can be configured in appsettings.json:
with the configuration code:
loggerConfiguration.ReadFrom.Configuration(cfg);In this case it is not possible to add default tags to the sink.
The PR adds the possibility to configure default tags in appsettings.json: