allow filtering of html #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethPaul
force-pushed
the
filter-html-options
branch
from
d0e13d9 to
e0ed956
Compare
|
Looks great, can you please help me add the tests, it will be great, thanks for the help ! |
|
Sorry, I was reluctant to add the tests since so much has to be mocked for this setting. Hard to confirm the actual behavior without just using the mcp but these at least help. Do these added tests seem to meet the need effectively? |
|
yes please |
|
@executeautomation can. this be merged ?? this seems like a very important fix. |
usamaJ17
approved these changes
Jun 5, 2025
|
Could this please get merged? Especially the option to get only the HTML of a specific element seems really important to reduce token count when giving the HTML output to an LLM |
executeautomation
approved these changes
Jun 19, 2025
|
This looks great, and the changes will be included in today’s release! |
executeautomation
merged commit 7993f03
into
executeautomation:main
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full html can add a lot of tokens to a chat context
This change set adds filtering prior to getting into the chat context