stub: should be executable #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kotp It won't show any changes here, but it does say it is executable now. I just wanted someone else to see it before this trivial change is merged 😄 |
IsaacG
approved these changes
Aug 4, 2019
|
Thank you. |
This was referenced Aug 4, 2019
Not true, it shows:
|
|
Ah, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized once I copied the stub to all exercises, that they weren't executable. I think we fixed our tests, so that none of them require an executable script, but that might not be the case.
I remember a lot of frustration the first time I came across a test requiring an executable solution script. BATS doesn't give a good error message for this.
Reviewer Resources:
Track Policies