review: "sync: output reimplements property (#317)"

[ee7]

Some suggestions for #317.

Changes:

• Make the tests pass.
• Add some parens. This is an opinionated change, and isn't a strict improvement in readability. But I think it helps make the codebase more reader-friendly when done consistently. It also currently improves the syntax highlighting on GitHub and in many editors.
• Bikeshed comment - I didn't love "output" and "value" because it could sound like it addresses sync: If a test case was added that reimplements another case, print the reimplemented UUID as well #61, but we'll address that elsewhere.

[ErikSchierboom]

I like it. I'm always unsure when to use parentheses.

[ee7]

Another reputation edge case: this PR awarded 12 rep. Is that what we want?

Maybe it should be worth 5, like a regular review. And then I shouldn't get another 5 from reviewing the parent PR too?

So maybe the rule should be "0 rep for a merged PR that does not target the main branch".

This style of reviewing is less common in Exercism repos, though. But I like it much better than GitHub's "suggested changes" - I can check that the code compiles and tests pass myself. And edit files/lines that weren't touched by the parent PR.

[ErikSchierboom]

Another reputation edge case: this PR awarded 12 rep. Is that what we want?
This style of reviewing is less common in Exercism repos, though. But I like it much better than GitHub's "suggested changes" - I can check that the code compiles and tests pass myself. And edit files/lines that weren't touched by the parent PR.

I think this is indeed quite uncommon, but might be worth discussing. We could add the reputation/contributed_code/minor label to reduce the amount of rep by 3.