Skip to content

Add linked list practice exercise #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Mar 1, 2023

The #12in23 challenge asks to do the linked-list exercise, which is currently not implemented and should be added during the month of March. See #566

  • add file skeleton
  • write tests
  • write example
  • write documentation
  • add .meta/tests.toml

@vaeng vaeng self-assigned this Mar 1, 2023
@vaeng vaeng linked an issue Mar 1, 2023 that may be closed by this pull request
@siebenschlaefer
Copy link
Contributor

The internal guideline for markdown files is one sentence per line, and to use reference links.
You could just copy the description.md from the problem-specification.

@vaeng vaeng requested a review from siebenschlaefer February 9, 2024 19:49
@vaeng vaeng marked this pull request as ready for review February 9, 2024 19:49
Copy link
Contributor

@siebenschlaefer siebenschlaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just one small issue: In the example solution pop() and shift() throw dynamically allocated exceptions. Most experts advise against that, throw them by value instead.

And in the tests the indentation is mostly four spaces but sometimes a tab.

@vaeng vaeng mentioned this pull request Feb 12, 2024
11 tasks
@vaeng vaeng added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels Feb 12, 2024
@vaeng vaeng merged commit f6a34aa into exercism:main Feb 12, 2024
@vaeng vaeng deleted the wip/add-linked-list branch February 12, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add practice exercise for linked list
2 participants