Skip to content

Add Robot Name Test Generator #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpreese opened this issue Sep 6, 2017 · 7 comments
Closed

Add Robot Name Test Generator #419

jpreese opened this issue Sep 6, 2017 · 7 comments

Comments

@jpreese
Copy link
Contributor

jpreese commented Sep 6, 2017

This issue is part of an overall initiative to complete #195.

The documentation on how to add generators can be found here. If you get stuck or have any questions about adding this generator, please do not hesitate to reach out!

Gimly added a commit to Gimly/csharp that referenced this issue Sep 29, 2017
Since this exercise has no canonical data, the generator is very simple.
Fixes exercism#419
@Gimly
Copy link

Gimly commented Sep 29, 2017

I'm not sure I'm getting how the generators work exactly. For this exercise, there is no canonical data specified, wouldn't that mean that the exercise doesn't need a generator?

@ErikSchierboom
Copy link
Member

Yes, if there is no canonical data for this exercise, there can't be a test generator. Sorry about that.

@Gimly
Copy link

Gimly commented Sep 29, 2017

No worries, I was quite confused. So I guess you can close this issue because this exercise doesn't have any canonical data.

@GKotfis
Copy link
Contributor

GKotfis commented Sep 29, 2017

I'm also trying to figure it out connection between canonical-data and generator. But I didn't find any canonical-data.json in this repository. So this issues are valid? :)

@Gimly
Copy link

Gimly commented Sep 29, 2017

@GKotfis The canoncial-data.json are defined in another repository, the https://github.com/exercism/problem-specifications which contains all the problem specifications (as the name says 😄).

If you run dotnet run in the generator folder of this repository then it will run all generators.

@ErikSchierboom
Copy link
Member

There is some documentation on the test generators here: https://github.com/exercism/csharp/blob/master/docs/GENERATORS.md

@robkeim
Copy link
Contributor

robkeim commented Sep 30, 2017

I'm closing this issue since there's no canonical data for this exercise.

@Gimly and @GKotfis thanks for looking into this! Feel free to update or suggest updates for the documentation for the generators as well. So far, we've had a very small group of contributors which hasn't forced us to be very rigorous with our documentation :)

@robkeim robkeim closed this as completed Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants