Skip to content

Kindergarten problem. Not clear which functions does what #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NobbZ opened this issue Sep 28, 2017 · 5 comments
Closed

Kindergarten problem. Not clear which functions does what #436

NobbZ opened this issue Sep 28, 2017 · 5 comments

Comments

@NobbZ
Copy link
Member

NobbZ commented Sep 28, 2017

@rwobben commented on Wed Sep 27 2017

Hello,

I try to solve the kindergarten challenge in c#. I see that there are 3 seperate functions given: Garden, GetPlants and DefaultGarden.

I think GetPlants must give me the answer to this problem.
But what schould the other two do exactly ?

Roelof


@NobbZ commented on Thu Sep 28 2017

Since this is a question spoecific to the C# version of the exercise (canonical data only knows about the property plants), I'll move you over there.

@NobbZ
Copy link
Member Author

NobbZ commented Sep 28, 2017

Let me chime in with possible solutions to this problem:

  • Remove all methods that are not part of the canonical data
  • Put documentational comments to the method declarations in the stub
  • extend the README of the exercise to explain the extended requirements

@ErikSchierboom
Copy link
Member

All very good points! I think we can solve this by better conforming to the canonical data, which should be done by creating a test generator for it: #411.

@NobbZ
Copy link
Member Author

NobbZ commented Sep 28, 2017

Perhaps try to explain here for now to make @rwobben able to continue with the exercise?

@ErikSchierboom
Copy link
Member

@NobbZ I'll do that tomorrow!

@ErikSchierboom
Copy link
Member

@NobbZ @rwobben The Garden.DefaultGarden method is static factory method that returns a new Garden instance with default child names. The Garden constructor allows you to specify the child names. Lastly the GetPlants method is an instance method of the Garden class, and returns the plants for the child name passed as its argument.

I'll be working on creating an updated version of the exercise to conform to the canonical data.

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this issue Jan 15, 2021
* [Docs] Add section on .meta/design.md document
* [Docs] Add .meta/design.md file to file trees
* [Docs] Use relative link
* [Docs] Put meta design last
* [Docs] Remove resources section
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this issue Jan 21, 2021
* [Docs] Add section on .meta/design.md document
* [Docs] Add .meta/design.md file to file trees
* [Docs] Use relative link
* [Docs] Put meta design last
* [Docs] Remove resources section
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this issue Jan 26, 2021
* [Docs] Add section on .meta/design.md document
* [Docs] Add .meta/design.md file to file trees
* [Docs] Use relative link
* [Docs] Put meta design last
* [Docs] Remove resources section
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this issue Jan 27, 2021
* [Docs] Add section on .meta/design.md document
* [Docs] Add .meta/design.md file to file trees
* [Docs] Use relative link
* [Docs] Put meta design last
* [Docs] Remove resources section
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this issue Jan 28, 2021
* [Docs] Add section on .meta/design.md document
* [Docs] Add .meta/design.md file to file trees
* [Docs] Use relative link
* [Docs] Put meta design last
* [Docs] Remove resources section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants