[WIP] xUnit - #196
Closed
ErikSchierboom wants to merge 22 commits into
Closed
Conversation
Contributor
|
@ErikSchierboom I'd love to look through this but I'm moving tomorrow and I won't have time before then. I'll be back online after my vacation the second weekend of March. I'm sure that you and @balazsbotond will keep everything up and running while I'm gone, and I'll "see" you soon! |
Member
Author
|
But of course. No problem! When you're back, I hope to have . net core working. |
Member
Author
|
This PR can be closed, as everything in this PR has been merged into #199. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to fix #193. There were several oddities, most notably the fact that xUnit doesn't out of the box handle nested enumerable equality. On the plus side, xUnit is now the preferred unit test framework for .NET Core and it will be very easy getting it to work there. Also, we no longer need a special case handling for AppVeyor (and possible CircleCI).
As there are so many changes, I'd really like a thorough review. If things are good, I think we should then leave it unmerged for a while, as otherwise we would have to adjust our documentation, which we would then have to anyway when we convert to .NET Core.
That would be the next thing I'm working on, converting to .NET Core. I will be doing that based on the code in this PR. Good times coming!